PATCH: Select audio output device without Custom Sink
Bug #871544 reported by
Dustin Spicuzza
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Exaile |
Fix Released
|
Medium
|
Dustin Spicuzza | ||
Bug Description
Currently, the only way to use an alternate audio device that is not the 'default' is to provide a custom audio sink argument with the correct parameters, which is highly inconvenient for the typical user to do. This patch provides a setting and a preferences object that enumerates available devices for those types of sinks that support it, and displays those options to the user.
This patch is against trunk r3893. Tested on Ubuntu 11.10.
Related branches
lp:~dustin-virtualroadside/exaile/dj_improvements
- Adam Olsen: Approve
-
Diff: 5692 lines (+2891/-448)68 files modifieddata/ui/preferences/playback.ui (+35/-2)
data/ui/preferences/playlists.ui (+15/-0)
plugins/audioscrobbler/__init__.py (+5/-5)
plugins/awn/__init__.py (+7/-7)
plugins/bpm/PLUGININFO (+4/-0)
plugins/bpm/__init__.py (+258/-0)
plugins/bpm/bpm.glade (+49/-0)
plugins/currentsong/__init__.py (+7/-7)
plugins/desktopcover/__init__.py (+10/-2)
plugins/equalizer/__init__.py (+2/-2)
plugins/grouptagger/PLUGININFO (+4/-0)
plugins/grouptagger/__init__.py (+273/-0)
plugins/grouptagger/gt_common.py (+297/-0)
plugins/grouptagger/gt_widgets.py (+406/-0)
plugins/history/PLUGININFO (+4/-0)
plugins/history/__init__.py (+311/-0)
plugins/history/history_preferences.py (+52/-0)
plugins/history/history_preferences.ui (+70/-0)
plugins/karaoke/__init__.py (+2/-2)
plugins/lyricsviewer/__init__.py (+6/-6)
plugins/minimode/controls.py (+11/-11)
plugins/moodbar/__init__.py (+4/-4)
plugins/mpris/mpris_player.py (+2/-2)
plugins/notify/__init__.py (+3/-3)
plugins/notifyosd/__init__.py (+8/-8)
plugins/replaygain/__init__.py (+4/-4)
plugins/streamripper/__init__.py (+4/-4)
xl/formatter.py (+8/-8)
xl/metadata/__init__.py (+11/-1)
xl/metadata/mp4.py (+6/-0)
xl/player/__init__.py (+2/-2)
xl/player/_base.py (+10/-9)
xl/player/adapters.py (+18/-14)
xl/player/engine_normal.py (+9/-6)
xl/player/engine_unified.py (+24/-20)
xl/player/pipe.py (+47/-41)
xl/player/queue.py (+20/-5)
xl/playlist.py (+16/-6)
xl/trax/search.py (+30/-2)
xl/trax/track.py (+7/-1)
xl/trax/trackdb.py (+9/-2)
xlgui/__init__.py (+2/-2)
xlgui/cover.py (+16/-13)
xlgui/main.py (+17/-10)
xlgui/menu.py (+5/-0)
xlgui/oldmenu.py (+24/-2)
xlgui/osd.py (+1/-1)
xlgui/panel/collection.py (+2/-2)
xlgui/panel/files.py (+2/-2)
xlgui/panel/flatplaylist.py (+4/-4)
xlgui/panel/playlists.py (+142/-33)
xlgui/panel/radio.py (+4/-4)
xlgui/playlist.py (+12/-11)
xlgui/preferences/__init__.py (+8/-11)
xlgui/preferences/playback.py (+8/-0)
xlgui/preferences/playlists.py (+4/-0)
xlgui/properties.py (+11/-1)
xlgui/tray.py (+14/-14)
xlgui/widgets/dialogs.py (+335/-7)
xlgui/widgets/filter.py (+10/-0)
xlgui/widgets/info.py (+19/-15)
xlgui/widgets/menuitems.py (+7/-8)
xlgui/widgets/notebook.py (+1/-0)
xlgui/widgets/playback.py (+58/-58)
xlgui/widgets/playlist.py (+75/-28)
xlgui/widgets/playlist_columns.py (+5/-4)
xlgui/widgets/queue.py (+12/-10)
xlgui/widgets/rating.py (+23/-22)
Revision history for this message
| Dustin Spicuzza (dustin-virtualroadside) wrote | #1 |
Revision history for this message
| Johannes Sasongko (sjohannes) wrote | #2 |
| Changed in exaile: | |
| milestone: | none → 0.3.3.0 |
| status: | New → In Progress |
| assignee: | nobody → Dustin Spicuzza (dustin-virtualroadside) |
Revision history for this message
| Johannes Sasongko (sjohannes) wrote | #3 |
| Changed in exaile: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Stefan Reich (at-1tef3n-n1) wrote | #4 |
Revision history for this message
| Johannes Sasongko (sjohannes) wrote Re: [Bug 871544] Re: PATCH: Select audio output device without Custom Sink | #5 |
Revision history for this message
| Dustin Spicuzza (dustin-virtualroadside) wrote | #6 |
Revision history for this message
| Dustin Spicuzza (dustin-virtualroadside) wrote | #7 |
| Changed in exaile: | |
| status: | Fix Committed → In Progress |
| Changed in exaile: | |
| importance: | Undecided → Medium |
| status: | In Progress → Fix Committed |
| Changed in exaile: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Thanks, it's something I've been interested in as well. Testing the patch as we speak.