TAB should cycle focus between search box, treeview and library

[jus]

Currently TAB alternate the input focus in a unfortunate way.

Is your current focus in the treeview, hitting TAB alternates to the search box , then to library only to get captured there. You can only jump between the different columns of the songs.

OTOH if your current focus in the library, you have no chance to set the focus to the search box or treeview with keyboard navigation.

In order to ease live performance Mixxx should wherever possible allow a mouse-free navigation.

I think it s a bug , not a missing feature.

[mutil (mutil)]

Here is a one-liner to disable tab key navigation in tableview

[RJ Skerry-Ryan (rryan)]

Thanks Mutil, I've committed your patch to the 1.10 branch.

Maybe we need a keyboard shortcut to focus the search box? That would make the process a lot nicer instead of having to hit tab a couple times. At least now the focus doesn't get stuck in the treeview.

[RJ Skerry-Ryan (rryan)]

Mutil, by what name would you like to be attributed in the Mixxx credits?

[mutil (mutil)]

Hey Ryan,
I made this patch which assigns 2 shortcuts:
1)Ctrl+F set focus to wsearchlinedit
2)Esc set focus to wtracktableview

I also changed the shortcut for mac fullscreen from Ctrl+F to Ctrl+Shift+F.

p.s. I am already in the mixxx credits as Thanasis Liappis from a previous patch.

[RJ Skerry-Ryan (rryan)]

Ah thanks, I thought you had already sent us a patch but wanted to make sure.

[jus (jus)]

Tested the patch from #4 on Mac OS X 10.6.8.
* The "Ctrl+F" shortcut is really useful (the de facto standard and long overdue in Mixxx)
* The "ESC" shortcut behavior is does not seem intuitive to me. A user likely wants to abort the search if he hit "ESC" , so it seems reasonable to clear the search results and jump to the last selected (highlighted) song in the unfiltered wtracktableview.
If he wants to use the filtered search results he can use the "TAB" shortcut as usual.

2 suggestions:
* If you circle with "TAB" between the different sections, it is not obvious whether or not wtracktableview is selected . We have no indication whatsoever. It should default to the last selected (highlighted) song. Currently using "TAB" forgets the last selected (highlighted) song as well.

* It would be useful if we could invoke the "TAB" behavior and searching via MIDI. Many controllers have dedicated buttons for that

[mutil (mutil)]

A slightly different patch where now "ESC" just clears the search field when this widget has focus (this is also the behaviour, amarok and banshee have).
Jus, I agree with the way you describe how it's reasonable for "ESC" to function (although, now I like the idea of having a shortcut for just clearing the search instead of multiple backspacing) but it needs more time to implement it that way.
I propose to have this one committed and see in the future what we can do to improve that (and maybe in a different bug as this one was for the tab key which has already been fixed).

[jus (jus)]

Your patch from #7 solves wishlist bug lp: 871140 (Escape should clear search box). You may add it there so we can track the separate issues more easily.

[jus (jus)]

Arrg, no edit function - should read:
"wishlist bug lp:871140 (Escape should clear search box)"

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6016