MASTER Firefox Crashed [@ComputePlaceholderContainment] [@nsViewManager::BuildDisplayList]

[Saibie]

Binary package hint: firefox

I was surfing www.autotrader.co.uk. When loading a new page Firefox crashed

ProblemType: Crash
Date: Wed Feb 21 18:31:10 2007
DistroRelease: Ubuntu 7.04
ExecutablePath: /usr/lib/firefox/firefox-bin
Package: firefox 2.0.0.1+1-0ubuntu1
ProcCmdline: /usr/lib/firefox/firefox-bin
ProcCwd: /home/sibe
ProcEnviron:
 SHELL=/bin/bash
 PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games
 LANG=en_GB.UTF-8
Signal: 11
SourcePackage: firefox
StacktraceTop:
 __kernel_vsyscall ()
 raise () from /lib/tls/i686/cmov/libpthread.so.0
 ?? ()
 ?? ()
 ?? ()
Uname: Linux sibe-desktop 2.6.20-8-generic #2 SMP Tue Feb 13 05:18:42 UTC 2007 i686 GNU/Linux
UserGroups: adm admin audio cdrom dialout dip floppy fuse lpadmin netdev plugdev powerdev scanner video

From retraced stacktrace:

...
#3 <signal handler called>
#4 ?? ()
#5 ComputePlaceholderContainment (aView=0x86714d8)
#6 nsViewManager::BuildDisplayList (this=0x83fef08,
#7 nsViewManager::BuildRenderingDisplayList (this=0x83fef08,
#8 nsViewManager::Refresh (this=0x83fef08, aView=0x86714d8,
#9 nsViewManager::DispatchEvent (this=0x83fef08,
#10 HandleEvent (aEvent=0xbfc90a3c) at nsView.cpp:171
#11 nsCommonWidget::DispatchEvent (this=0x944d8c8,
#12 nsWindow::OnExposeEvent (this=0x944d8c8, aWidget=0x8276148,
#13 expose_event_cb (widget=0x8276148, event=0xbfc90ff4)
#14 _gtk_marshal_BOOLEAN__BOXED (closure=0x8384190,
#15 IA__g_closure_invoke (closure=0x8384190,
...

[Roc-ocallahan (roc-ocallahan)]

I can't reproduce on Mac in release or debug builds, nor in a Linux release build (SUSE). Martijn, can you?

[Martijn-martijn (martijn-martijn)]

No, I can't reproduce this on windows, neither with current branch or trunk builds.
Isn't that stacktrace of a trunk build?

[Saibie (s-galien)]

Binary package hint: firefox

I was surfing www.autotrader.co.uk. When loading a new page Firefox crashed

ProblemType: Crash
Date: Wed Feb 21 18:31:10 2007
DistroRelease: Ubuntu 7.04
ExecutablePath: /usr/lib/firefox/firefox-bin
Package: firefox 2.0.0.1+1-0ubuntu1
ProcCmdline: /usr/lib/firefox/firefox-bin
ProcCwd: /home/sibe
ProcEnviron:
 SHELL=/bin/bash
 PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games
 LANG=en_GB.UTF-8
Signal: 11
SourcePackage: firefox
StacktraceTop:
 __kernel_vsyscall ()
 raise () from /lib/tls/i686/cmov/libpthread.so.0
 ?? ()
 ?? ()
 ?? ()
Uname: Linux sibe-desktop 2.6.20-8-generic #2 SMP Tue Feb 13 05:18:42 UTC 2007 i686 GNU/Linux
UserGroups: adm admin audio cdrom dialout dip floppy fuse lpadmin netdev plugdev powerdev scanner video

[Hilario J. Montoliu (hjmf) (hmontoliu)]

Retrace done.

Marked as mt-confirm for further analysis.

[Mkmelin+mozilla (mkmelin+mozilla)]

*** Bug 411524 has been marked as a duplicate of this bug. ***

[Mkmelin+mozilla (mkmelin+mozilla)]

Roc, Martijn: from the dupe which crashes here http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/view/src/nsViewManager.cpp&mark=2342&rev=MOZILLA_1_8_BRANCH#2342

it seems pretty clear aView is null. Should we just add a check?

[Roc-ocallahan (roc-ocallahan)]

No, that would just mask a deeper bug.

[Alexander Sack (asac)]

not sure if ffox 3 is still affected. lets wait for dupes there.

[Alexander Sack (asac)]

ffox 2 won't receive a fix for this anymore.

[Jruderman (jruderman)]

roc, do you know what the "deeper bug" is? From the dup, it sounds like this was fixed in Firefox 3.

[Roc-ocallahan (roc-ocallahan)]

That bug would have been a call to nsViewManager::BuildDisplayList with null aView. However, we removed nsViewManager::BuildDisplayList in Firefox 3.

[Micah Gersten (micahg)]

Upstream says this was fixed in Firefox 3, so I am closing Fix Released.