ZORBA_ERROR_* macros still used

[Paul J. Lucas]

These old macros are still being used to report errors, e.g., LoadSchemaErrorHandler.cpp lines 67, 86. Additionally, English-only text is being used to construct error messages on-the-fly. All error messages need to have text referenced symbolically via diagnostic dictionary keys and thus be able to be localized.

Please replace all uses of these macros with "throw XQUERY_EXCEPTION( ..., ERROR_PARAMS( ... ), ERROR_LOC( ... ) );" and move all English-only strings to diagnostic_en.xml.

[Cezar Andrei (cezar-andrei)]

Fixed.

[Paul J. Lucas (paul-lucas)]

You are still constructing English-only messages on the fly. No English error messages can be hard-coded. All such error strings MUST go into the diagnostics dictionary.

[Chris Hillery (ceejatec)]

Paul - it seems as though the code you were referencing got corrected at some point. I don't see any uses of macros starting with ZORBA_ERROR_ any more.

Can you confirm that all the bad code is gone in core Zorba? If so, please remove any remaining vestiges; I see:

1. "#define ZORBA_ERROR_DESC_OSS ..." in xquery_diagnostics.h (no longer used)
2. "bool const useParam; // if true, msg is a parameter for the ZORBA_ERROR_LOC_PARAM() macro" in parsenode_base.h

which seem undesirable now.