xqdoc dependency to zorba is wrong

[Sorin Marian Nasoi]

Hello Sorin

I guess you are the right guy for this:
Today, I tried to execute 'make xqdoc' on a clean build. Unfortunately, it doesn't work because 'make xqdoc' is not dependent on zorba-cmd. Thus, I got the following error msg:

[100%] Building XQDoc XML documentation for the modules...
/bin/sh: ../../../bin/zorba: not found
make[3]: *** [doc/zorba/xqdoc/CMakeFiles/xqdoc-xml] Error 127
make[2]: *** [doc/zorba/xqdoc/CMakeFiles/xqdoc-xml.dir/all] Error 2
make[1]: *** [doc/zorba/xqdoc/CMakeFiles/xqdoc.dir/rule] Error 2

I though I can fix it be doing the following:

Index: doc/zorba/xqdoc/CMakeLists.txt
===================================================================
--- doc/zorba/xqdoc/CMakeLists.txt (revision 11112)
+++ doc/zorba/xqdoc/CMakeLists.txt (working copy)
@@ -51,7 +51,7 @@
      COMMENT "Building XQDoc XML documentation for the modules..."
  )
  #SET_TARGET_PROPERTIES(xqdoc-xml PROPERTIES EXCLUDE_FROM_DEFAULT_BUILD 1)
- ADD_DEPENDENCIES(xqdoc-xml zorba_simplestore)
+ ADD_DEPENDENCIES(xqdoc-xml zorbacmd_simplestore)

  ADD_CUSTOM_TARGET(xqdoc
    ${ZORBA_EXE_SCRIPT}
Index: cmake_modules/ZorbaModule.cmake
===================================================================
--- cmake_modules/ZorbaModule.cmake (revision 11112)
+++ cmake_modules/ZorbaModule.cmake (working copy)
@@ -543,7 +543,7 @@
  )
  #SET_TARGET_PROPERTIES(xqdoc-xml-${PROJECT_NAME} PROPERTIES EXCLUDE_FROM_DEFAULT_BUILD 1)
  IF(TARGET xqdoc-xml)
- ADD_DEPENDENCIES(xqdoc-xml-${PROJECT_NAME} zorba_simplestore)
+ ADD_DEPENDENCIES(xqdoc-xml-${PROJECT_NAME} zorbacmd_simplestore)
    ADD_DEPENDENCIES(xqdoc-xml-${PROJECT_NAME} xqdoc-xml)
    ADD_DEPENDENCIES(xqdoc xqdoc-xml-${PROJECT_NAME})
  ENDIF(TARGET xqdoc-xml)

But it doesn't help. Can you take a look into it?

Thanks
David

[Chris Hillery (ceejatec)]

IMHO, this is not critical for 2.0; marked as such.

[Sorin Marian Nasoi (sorin.marian.nasoi)]

Decreased the priority according to the issue being marked Zorba 2.1

As a separate thing: if Zorba is build as a static library the names of the necessary dependencies for xqdoc also change.

Chris suggested that if nothing else it won't work for Sausalito when they build with their store. I'm not sure what the target name changes to when building static off the top of my head, though... there should probably be a CMake variable somewhere that is set to the name of that target.

[Sorin Marian Nasoi (sorin.marian.nasoi)]

Marked with Resolution = None at Dana's request.

[Sorin Marian Nasoi (sorin.marian.nasoi)]

@David, can you please check if this is still a problem?

Thanks,
Sorin

[David Graf (davidagraf)]

Yes, it is still a problem. It is very easy to reproduce:

1) make
2) rm bin/zorba
3 make xqdoc

=>
make xqdoc
[100%] Built target zorba_simplestore
Scanning dependencies of target xqdoc-xml
[100%] Building XQDoc XML documentation ...
/bin/sh: bin/zorba: not found
make[3]: *** [CMakeFiles/xqdoc-xml] Error 127
make[2]: *** [CMakeFiles/xqdoc-xml.dir/all] Error 2
make[1]: *** [CMakeFiles/xqdoc.dir/rule] Error 2
make: *** [xqdoc] Error 2