Wrong errors reported for computed elem and attr constructor

[Gabriel Petrovay]

According to the XQuery 1.0 spec, this should fail with error err:XQDY0096
element { "xmlns:foo" } {}

This means that the check for xmlns has to be made before the casting to xs:QName which will throw err:XQDY0074.

[Gabriel Petrovay (gabipetrovay)]

I added a test for this which is currently failing:

test/rbkt/zorba/constructors/element_xmlns_prefix

[Nicolae Brinza (nbrinza)]

This is not correct. Please read the specs more carefully.

http://www.w3.org/TR/xquery/#id-computedElements --

"If conversion of the atomized name expression to an expanded QName is not successful, a dynamic error is raised [err:XQDY0074]."

[Nicolae Brinza (nbrinza)]

Please also remove the incorrect test and the expected failure.

[Gabriel Petrovay (gabipetrovay)]

err:XQDY0074 is the general case for:
That is the general case for:
element { "one:two:three" } {}

This means tha an invalid string literal has been passed and cannot be convertd to xs:QName.

But the provided string literal is syntactically correct, like "err:foo". Both have also a defined namespace URI in the static context.
err: http://www.w3.org/2005/xqt-errors
xmlns: http://www.w3.org/2000/xmlns/

The next paragraph in the spec handles specifically this case: invalid values for the namespace prefix and URI.

Do you have case where err:XQDY0096 is thrown? If you don't, that means that this part of the spec is not implemented.

The same problems appear also with attributed: err:XQDY0044

[Nicolae Brinza (nbrinza)]

I've made the change so that XQDY0096 is reported, but there is an open bug with the W3C that will make XQDY0074 a valid error for this case, see http://www.w3.org/Bugs/Public/show_bug.cgi?id=11434 .

[Gabriel Petrovay (gabipetrovay)]

And a similar patch for attributes is needed:

element { "err:foo" } { attribute { "xmlns:attr" } {} }

[Nicolae Brinza (nbrinza)]

Fixed

[Matthias Brantner (matthias-brantner)]

confirmed (for Gabriel) in rev. 9554