Located URI visibility test incorrect

[Mike Rylander]

Located URIs should be visible when they exist at the search context org unit or an ancestor thereof. However, before the change embodied in the below linked branches (master and 2.1) they effectively acted exactly like copies, making records visible anywhere within the context+depth range.

An example, using the stock example OU hierarchy:

 * Before this change, a Located URI with an owner of BR1 would cause its record to show up in a search at (or scoped to via a depth parameter) BR1, SYS1 or CONS.

 * Before this change, a Located URI with an owner of SYS1 would NOT cause its record to show up in a search at (or scoped to via a depth parameter) BR1!

 * After this change, a Located URI with an owner of BR1 will cause its record to show up only in a search with a context OU of BR1, irrespective of depth scoping.

 * After this change, a Located URI with an owner of SYS1 WILL cause its record to show up in a search with a context OU of BR1 or SYS1, regardless of depth scoping.

Branch for master: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/miker/located_uri_visiblity_fix

Branch for rel_2_1: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/miker/located_uri_visiblity_fix_2_1

[Ben Shum (bshum)]

Hand patched a version of this for our local 2.0 test systems. I showed it to some of our catalogers here and they like the direction of the change; though all of our subfield 9 entries were written at BR1 level instead of SYS1 level, per example, so we have to redo them to appear appropriately at the right levels now.

That said, consider us a +1 vote to having this merged in for future versions. Having it backported to rel_2_0 would be nice too. Thanks!

[Mike Rylander (mrylander)]

As requested: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/miker/located_uri_visibility_fix_2_0

Merging that is a toss up. I leave that as an open question to interested parties.

[Dan Scott (denials)]

Tested; works as promised. Committed to master and rel_2_1. Thanks Mike!

[Jason Stephenson (jstephenson)]

Seems a bit late in the cycle to fix this in 2.0. It would require users to change their located URIs.