CR in invoice_line_note

Bug #865497 reported by Ferdinand
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Confirmed
Wishlist
OpenERP R&D Addons Team 3

Bug Description

6.0 hr_timesheet_invoice creates empty lines with CR in note if
none of the boxes in
"Do you want to show details of work in invoice"
is checked.

Revision history for this message
Ferdinand (office-chricar) wrote :
Revision history for this message
Vishal Parmar(Open ERP) (vpa-openerp) wrote :

Hello Ferdinand,

Would you please elaborate more on this issue like from where you did checked "Do you want to show details of work in invoice".

Thanks and waiting for your reply.

Changed in openobject-addons:
status: New → Incomplete
Revision history for this message
Ferdinand (office-chricar) wrote :

hr_timesheet_invoice - wizard

Changed in openobject-addons:
status: Incomplete → New
Revision history for this message
Vishal Parmar(Open ERP) (vpa-openerp) wrote :

Hello Ferdinand,

In wizard If you checked description then it will showing the note other wise not. Would you please checked attached video and notify us where you faced the problem.

Thanks and waiting for your reply.

Revision history for this message
Vishal Parmar(Open ERP) (vpa-openerp) wrote :
Changed in openobject-addons:
status: New → Incomplete
Revision history for this message
Ferdinand (office-chricar) wrote :

please
my example is - uncheck ALL options is shown in #3

AND please use multiple lines (>1) which must end up in the same invoice
example
task work of 2 days

Revision history for this message
Ferdinand (office-chricar) wrote :

FYI
select length(replace(note,'\n','')),length(note) from account_invoice_line where note like '%\n%' and length(replace(note,'\n',''))=0;

gives

 length | length
--------+--------
      0 | 4
      0 | 22
      0 | 3
      0 | 8
      0 | 3
      0 | 24
      0 | 1
      0 | 8
      0 | 2
      0 | 12
      0 | 6
      0 | 3
      0 | 17
      0 | 6

Revision history for this message
Vishal Parmar(Open ERP) (vpa-openerp) wrote :

Hello Ferdinand,

yes, I agree with you for comment #7 but name field is required field so you must have to fill-up, In wizard

"Do you want to show details of work in invoice" it self say if you show details then checked other wise not.

if you not check any one of them option then it will not show but it's length is store in db.Would you please

checked attached video and informed me where you faced the problem.

Thanks and waiting for your reply.

Revision history for this message
Vishal Parmar(Open ERP) (vpa-openerp) wrote :
Revision history for this message
Ferdinand (office-chricar) wrote :

what I am saying is:

even if NO details are checked to show in invocie, for every line ONE LF (not CR as stated) is stored

hence
- if line.note and len(line.note.replace('\n','')) > 0 :
is necessary to check if the note is empty

On the screen nothing is shown and visible hence your video does not help.

Revision history for this message
Vishal Parmar(Open ERP) (vpa-openerp) wrote :

Hello Dr.Ferdinand,

Would you please check attached video.

Thanks and waiting for your reply.

Revision history for this message
Ferdinand (office-chricar) wrote :

in the video you do not see the problem because \n are not visible

Revision history for this message
Vishal Parmar(Open ERP) (vpa-openerp) wrote :

Hello,
I agree with Dr.Ferdinand necessary to check if the note is empty.
It Required changes regarding the improvement in bug specification(as per #10).currently I can consider this issue as wishlist.
Thanks.

Changed in openobject-addons:
assignee: nobody → OpenERP R&D Addons Team 3 (openerp-dev-addons3)
importance: Undecided → Wishlist
status: Incomplete → Confirmed
tags: added: hr invoice timesheet
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.