Filter buttons on Purchase List do not work properly

[jlinkels]

Server 6.0.3
GTK client 6.0.3
Using the demo database, Dutch Accounting scheme

The buttons "To Approve" and "Not Invoiced" do not have the desired functionality.
When I create a Purchase Order and leave it in "Request for Quotation" state, it shows up in the list of Purchase Orders when no filter buttons are active. That is correct.

When I click the "To Approve" button, the PO disappears. It should remain visible, because it has to be approved.
I convert the PO to an actual PO by pressing the "Convert to PO" button on the PO form.
Back to the list, I click the "Approved" button. Now this PO shows up.
Apparently by creating purchase order I approved the PO.
The "To Approve" and "Approved" buttons should show mutually exclusive list of PO's but they don't. The "To Approve" button hides ALL PO's.

When I have approved the PO, it is NOT invoiced yet. The field "invoiced" shows 0%
However, when I click the "Not Invoiced" button, this PO disappears.
Clicking the "Not Invoiced" button shows the "Not Approved" PO instead.
When I click the "Not Invoiced" button, I should see PO's which are not invoiced, that is the invoiced field < 100%

This bug seems to be somewhat related with Bug #692254, but the button functionality is clearly off.

jlinkels

[Atik Agewan(OpenERP) (aag-openerp)]

Hello jlinkels,

  I am Agree with "To Approve" button will show Purchase order which are yet not approved.
so I have fixed it in lp:~openerp-dev/openobject-addons/trunk-bug-864970-aag
Revision ID: <email address hidden>,
Revision num: 5291.

But "Not Invoiced" will not showe PO with invoiced field < 100% ,
It will showe List of PO in which Invoices are not created.
It is working properly.so, we can not improve "Not Invoiced" button's functionality,

Thanks,
 Atik

[jlinkels (jlinkels)]

> But "Not Invoiced" will not showe PO with invoiced field < 100% ,
> It will showe List of PO in which Invoices are not created.
> It is working properly.so, we can not improve "Not Invoiced" button's functionality,

I confirm that according to that explanation the buttons behave as you say.

However looking at the work flow this is the process
Sales Dept: Create Draft Sale Order -> Confrim Sales Order -> Create Invoice
Accountancy: Open Invoice -> Confirm Invoice

For the Sales Dept, the work is done when they have created the invoice.
It is highly confusing that in the Sales Order list a Sales Order shows 0% invoiced
while the Accounting Dept has not confirmed it.

Even more confusing is that in this step (Accounting did not confirm the invoice)
the sales order line shows "Invoiced 0%" while the button "To Invoice" does
NOT show invoices which are not confirmed.

This is a Sales Dept screen, and it should show the Sales Dept workflow,
and not intermix it with what Accounting has done or not, without
properly indicating that this is an Accounting issue.

Maybe the functionality is correct, but the user interface is not. User expect
consistency. When an order is 0% invoiced, either it should show up when I
press the button "To Invoice", or the labels should be changed showing clearly
the difference between "Invoiced by the Sales Dept" and "Confirmed by Accounting"

jlinkels

[qdp (OpenERP) (qdp)]

fix released in revision 5397

thanks

[jlinkels (jlinkels)]

Thanks for fixing

jlinkels