Remote Edit looses overridden theme

Bug #864822 reported by Tim Bentley
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenLP
Fix Released
Undecided
Tim Bentley

Bug Description

When a song is edited in the servicemanager if the theme has been overridden the original theme is replaced on save.
Preserve the theme in the service item.

Related branches

Tim Bentley (trb143)
Changed in openlp:
status: New → In Progress
assignee: nobody → Tim Bentley (trb143)
milestone: none → 1.9.8
Tim Bentley (trb143)
Changed in openlp:
status: In Progress → Fix Released
description: updated
Revision history for this message
John Cegalis (jseagull1) wrote :

Kubuntu build 1795

I imported three new songs to the media manager from CCLI. When I did they should my theme of "lyrics". I moved them to the Service side and the theme showing is my "verses" theme which is the song level theme at the top. I tried editing the song on the service side and changed the theme and nothing changes when Saved. The only way to change the theme is from the right click context menu "Change Item Theme".

I also tried opening OpenLP and a service file, went directly in to song edit on the service side and changed the theme and it did not change. I even tried closing OpenLP and opening it again and it displayed the original theme and not the changed theme in song edit.

Revision history for this message
Andreas Preikschat (googol-deactivatedaccount) wrote :

Re-opened, as it does not seem to be fixed for John.

Changed in openlp:
status: Fix Released → Confirmed
Revision history for this message
Tim Bentley (trb143) wrote :

Sorry this is not a bug and cannot be fixed.
what you are asking for is for the change to be backed out and the song to always take a theme from the song.
How does it know what theme to use?

If you deleted the song from the servicemanager then all would be fine!

If you think this is a bug then can you explain, for all situations what should happen and when we should preserve the override and when we should not. Or is that the answer have a flag to say theme overridden and only copy on that?

Revision history for this message
John Cegalis (jseagull1) wrote :

Here is my thought, any song that has a theme assigned to it in song edit should not pickup the default universal theme under any circumstance. My second line above that says "should" was supposed to be "showed", sorry for the typo.

When I added the songs into the media manager it automatically assigned them my theme called "lyrics". When I added the songs to the service manager it did not use the "lyrics" theme that was assigned to it, it used the default universal theme that was showing above. The only way to change it was from the context menu.

The other thing I don't understand is why it assigned any theme when I added the new songs. It used to leave that blank until I assigned it in song edit.

Sure hope I answered your question.

Tim Bentley (trb143)
Changed in openlp:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.