Custom BPM Schemes got deleted when reopening Mixxx
Bug #864574 reported by
jus
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mixxx |
Fix Released
|
Medium
|
RJ Skerry-Ryan | ||
| 1.10 |
Fix Released
|
Medium
|
RJ Skerry-Ryan | ||
| 1.9 |
Fix Released
|
Medium
|
RJ Skerry-Ryan | ||
Bug Description
Tested with latest lp:mixxx/1.10 r 2846 on MacOS 10.6.8
Steps to reproduce:
1. Add a new BPM schemes in Preferences->BPM Detection
2. Hit OK button, new custom scheme is saved to mixxxbpmscheme.xml
3. Close and reopen Mixxx
Actual behavior:
mixxxbpmscheme.xml got replaced with an empty file , the custom BPM schemes are gone
Expected behavior:
The custom BPM schemes should still be in mixxxbpmscheme.xml and ready to use
Also we could include some schemes for different genres to choose from per default if this helps to improve BPM detection. See the attached custom mixxxbpmscheme.xml
| Changed in mixxx: | |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
Revision history for this message
| RJ Skerry-Ryan (rryan) wrote | #2 |
Revision history for this message
| RJ Skerry-Ryan (rryan) wrote | #3 |
| Changed in mixxx: | |
| assignee: | nobody → RJ Ryan (rryan) |
| status: | Confirmed → Fix Committed |
| Changed in mixxx: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Swiftb0y (swiftb0y) wrote | #4 |
| lock status: | Metadata changes locked and limited to project staff |
To post a comment you must log in.
A really dumb bug and I'm not sure why it worked in the past but not now. My current theory is QDomDocument used to not pay attention to the 'encoding="UTF-16"' line we were putting in mixxxbpmscheme.xml but at some point that was changed. Our bug is that we put 'encoding="UTF-16"' in the file, but then we don't encode it as UTF-16.