insert key delete message

Bug #864184 reported by Borim
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Undecided
Unassigned

Bug Description

when you press the numpad 0 key the high lighted message is deleted/moved to archive.

the appended patch change the key value. So that you can delete a message with numpad period key.

Related branches

Revision history for this message
Borim (borim) wrote :
Revision history for this message
Borim (borim) wrote :

as branches are preferred, here is the branch :)

Revision history for this message
SirVer (sirver) wrote :

borim, what was your itention with this patch? Add , as deletion key and REMOVE 0 or only add , and KEEP 0? Also, what was the motivation behind these changes?

Also, the key changes should be documented in txts/README.

Changed in widelands:
status: New → Incomplete
Revision history for this message
Borim (borim) wrote :

when I add the different numpad keys for PgUp and so on, I discovered that you can use numpad insert/0 to remove a message. I think it is a little bit weired using a insert key for a deleting operation. So I changed it to numpad del, which is equal to the numpad period key.

by the way, I noticed that during the time between the patch creation and the branch creation, the numpad insert key was removed from the delete message handler. I do not know why, but in my opinion: if you can use the numpad keys instead the "normal" keys. You should be able to do so with all availible keys and not only a subset.

so in short: add the numpad del/, key and remove numpad ins/0

should the txts/README be updated although the simple del key is already documented as archive message?

Revision history for this message
SirVer (sirver) wrote :

I merged this in r6020. I wasn't aware that period is deletion on numpad, on my keyboards this was never labeled that way. No further mentioning in the README is needed then.

Changed in widelands:
status: Incomplete → Fix Committed
milestone: none → build17-rc1
Revision history for this message
SirVer (sirver) wrote :

Released in build17-rc1.

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.