library state will require explicit initialisation (but not yet)

Bug #863401 reported by Jelmer Vernooij
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
Critical
Vincent Ladeuil

Bug Description

previously it was possible to import from bzrlib without initializing it explicitly. In bzr.dev this no longer works:

$ python fetch.py
Traceback (most recent call last):
  File "fetch.py", line 3, in <module>
    from bzrlib.branch import Branch
  File "/home/jelmer/src/bzr/bzr.dev/bzrlib/branch.py", line 2382, in <module>
    __format5 = BzrBranchFormat5()
  File "/home/jelmer/src/bzr/bzr.dev/bzrlib/branch.py", line 2082, in __init__
    self._matchingbzrdir = bzrdir.BzrDirMetaFormat1()
  File "/home/jelmer/src/bzr/bzr.dev/bzrlib/lazy_import.py", line 121, in __getattribute__
    obj = _replace()
  File "/home/jelmer/src/bzr/bzr.dev/bzrlib/lazy_import.py", line 90, in _replace
    obj = factory(self, scope, name)
  File "/home/jelmer/src/bzr/bzr.dev/bzrlib/lazy_import.py", line 211, in _import
    module = __import__(module_python_path, scope, scope, [member])
  File "/home/jelmer/src/bzr/bzr.dev/bzrlib/bzrdir.py", line 2292, in <module>
    format_name = config.GlobalStack().get('default_format')
  File "/home/jelmer/src/bzr/bzr.dev/bzrlib/config.py", line 3306, in __init__
    [bzrlib.global_state.cmdline_overrides, gstore.get_sections],
AttributeError: 'NoneType' object has no attribute 'cmdline_overrides'

Marking this as critical as almost all 3rd party users don't call .initialize.

Related branches

Vincent Ladeuil (vila)
Changed in bzr:
assignee: nobody → Vincent Ladeuil (vila)
status: Confirmed → In Progress
Vincent Ladeuil (vila)
summary: - now requires explicit initialization
+ library state now requires explicit initialization
Vincent Ladeuil (vila)
Changed in bzr:
milestone: none → 2.5b2
Vincent Ladeuil (vila)
summary: - library state now requires explicit initialization
+ library state now (yet) requires explicit initialization
summary: - library state now (yet) requires explicit initialization
+ library state will requires explicit initialization (but not yet)
Changed in bzr:
status: In Progress → Fix Released
Vincent Ladeuil (vila)
summary: - library state will requires explicit initialization (but not yet)
+ library state will requires explicit initialisation (but not yet)
Vincent Ladeuil (vila)
summary: - library state will requires explicit initialisation (but not yet)
+ library state will require explicit initialisation (but not yet)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.