cobbler-enlist is not checking for return codes enough

[Jamie Strandboge]

In performing the MIR audit for cobbler-enlist (bug #860492), I discovred:

- PROBLEM: most xmlrpc_* calls are not doing any error checking, but should be based on looking at code of xmlrpc-c.
- RECOMMENDATION: create utility function wrappers for the common xmlrpc-c comamnds, have the cobbler-enlist code use the wrappers, and have the wrappers do all the error checking. Eg: all current uses of xmlrpc_array_new(...) should be changed to use ce_xmlrpc_array_new(...), then ce_xmlrpc_array_new() calls xmlrpc_array_new() and does the necessary error checking and fails. This should be done everywhere that an xmlrpc function is used a lot, and for those things that are used only once, simply do it inline (eg for xmlrpc_server_info_new()).

This needs to get fixed so that cobbler-enlist is defensively coded. This must happen before 12.04 and I think it would also be good for SRU.

[Adam Gandelman (gandelman-a)]

Marking Invalid since we'll be moving forward with a rewrite of the utility.

[Jamie Strandboge (jdstrand)]

Umm, a total rewrite invalidates the security audit I performed for bug #860492. Why is this being done?

[Rolf Leggewie (r0lf)]

oneiric has seen the end of its life and is no longer receiving any updates. Marking the oneiric task for this ticket as "Won't Fix".