[6.0] Picking validation has rounding errors with digital precisions

[Marco Dieckhoff]

Error messages in Picking validation use the %d formatter for error messages.
This surpresses digits and you may end up with rounded (down) values.

Look at the example picture with values <1
"Processing quantity 0 [tons] for [product] is larger than the available quantity 0 [tons]!"

[Marco Dieckhoff (dieck)]

Fixed these problems in lp:~dieck/openobject-addons/6.0-d_vs_f, using dp digital precisions and %s variables, to allow translations, without having one for every digital precision.

Found (only) one more occurence of this problem in point_of_sale.

[Rifakat Husen (OpenERP) (rha-openerp)]

Hello Marco Dieckhoff,

We really appreciate your efforts and contribution towards community.

A much effective fix has been applied in this branch,
lp:~openerp-dev/openobject-addons/6.0-opw-17871-rha
Revision ID: <email address hidden>
Revision 4859

Can you please check it out whether it works for you or not?
Thank you very much for your good work!

Best regards.

[Marco Dieckhoff (dieck)]

The solution in lp:~openerp-dev/openobject-addons/6.0-opw-17871-rha does not use the decimal precision, it simply uses %s instead of %d.

This way, you end up with the default python %s precision for floats of 6 decimals.

So, it would work for everyone who uses a decimal precision of 6 or less, but not for people who uses a decimal precision of 7 or above (though I doubt there are many of them).

But if you e.g. use only a precision of 2, you are presented with 6 decimals on these messages, which may be confusing for the basic user.

I encourage using the appropriate configurable decimal precision.

[Marco Dieckhoff (dieck)]

If my branch lp:~dieck/openobject-addons/6.0-d_vs_f is considered to be used, please note: the changes made to the .po files are incomplete in my branch and should be taken from rha.

[Raphael Collet (OpenERP) (rco-openerp)]

Dear Marco,

I had a careful look at your branch, and I appreciate your fix.
I second your argument regarding the decimal precision of numbers in those messages.

I will merge both your branch and Rifakat's, and add the missing translation terms.

Many thanks for your contribution,

Raphael Collet

[Rifakat Husen (OpenERP) (rha-openerp)]

Landed into stable,
r4865, Revision ID: <email address hidden>
r4864 Revision ID: <email address hidden>

Best regards.