Verify Session in SIP2 fee payment

Bug #859970 reported by Jason Stephenson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned

Bug Description

When doing a checkout or checkin, the SIP2 code in Evergreen will verify the Evergreen login session and login again if it fails to find an active session. It does so by calling $self->verify_session.

The SIP->pay_fee method does not presently do this. A forthcoming branch will rectify this oversight.

Revision history for this message
Jason Stephenson (jstephenson) wrote :

And, here's the branch:

You need only add the remote once, regardless of how many branches you wish to look at.
To add this repo as working:
 Read-only (git protocol):
  git remote add working git://git.evergreen-ils.org/working/Evergreen
 Read-write (ssh protocol):
  git remote add working <email address hidden>:working/Evergreen

Once you have the remote added you can check out this branch:
git checkout -b lp859970 working/collab/dyrcona/lp859970

tags: added: pullrequest
Revision history for this message
Dan Scott (denials) wrote :

Looks good. We don't offer fee payments in our system, but the code path seems pretty clear. Committed to master.

Changed in evergreen:
status: New → Fix Committed
milestone: none → 2.2.0
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.