Various TPac fixes

[Thomas Berezansky]

Over the weekend I wrote up some Template Toolkit OPAC fixes:

I found some missing quotes for fine payment code

Made it so that you aren't prompted to pay fines in the OPAC if it is disabled

Added a default password strength rule that should match the others already in various places in the system

Fixed bolding of bad email/username on change attempts

And made OU dropdowns obey the opac_visible flag. Unless you are in the staff client.

And due to how I was working on them, they are all in one branch:
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/tsbere/tpac_fixes

[Dan Scott (denials)]

For "prevent pay fines in OPAC if disabled", it's good as far as it goes, but perhaps we should go further and make https://localhost/eg/opac/myopac/main_payment_form? return a blank page or 404 or something other than a payment form?

[Dan Scott (denials)]

I've tested and pushed the following commits to master:

  * missing quotes for fine payment code
  * do not prompt to pay fines in the OPAC if CC payments are disabled
  * fix bolding of bad email/username on change attempts
  * make OU dropdowns obey the opac_visible flag

I've left the "default password strength" out of this set of commits to master, as I'm concerned about propagating the default rule in hard-to-customize Perl module code rather than having the default rule come from the OU settings.

[Dan Scott (denials)]

I'm going to mark this as "Fix committed" as the bulk of the changes were indeed committed; please open a new bug specific to the "default password strength" change to focus on that issue.