building will burn down after upgrading and moving soldiers inside

[lowne]

when starting to upgrade a military building the enemy took over a building. Still upgrading the enemy took over another building near by. When upgrade were ready some soldiers tried to move in but the building just burned down.

[Hans Joachim Desserud (hjd)]

Thanks for reporting this, lowne.

I am not able to watch the replay since it has some problems since it becomes unsynchronized and goes to pause. Though, based on the screenshot, something seems to happen when the building is occupied. I guess it has something to do with the borders, but I don't see how the finished buildings should be destroyed as long as the construction site is allowed to live.

Also, I will edit the tags a bit. See http://wl.widelands.org/wiki/TriagingBugs/#official_widelands_bug_tags for a list of official tags used.

[SirVer (sirver)]

Setting to incomplete for bug sweeping.

[Launchpad Janitor (janitor)]

[Expired for widelands because there has been no activity for 60 days.]

[SirVer (sirver)]

Setting to incomplete for bug sweeping.

[Launchpad Janitor (janitor)]

[Expired for widelands because there has been no activity for 60 days.]

[GunChleoc (gunchleoc)]

The attached savegame reproduces the bug. It happens when the building is sitting on the border. There are 2 possible solutions:

1. Burn down the construction site and the unoccupied building
2. Keep the site intact when the soldiers move in

I am in favor of 1.

[kaputtnik (franku)]

Running your save game the widelands crashes here as soon the first soldier tries to enter the Outpost:

widelands: ../src/logic/editor_game_base.cc:576: virtual void Widelands::EditorGameBase::do_conquer_area(Widelands::PlayerArea<Widelands::Area<Widelands::FCoords> >, bool, Widelands::PlayerNumber, bool, bool, bool): Assertion `preferred_player != player_area.player_number' failed.
Abgebrochen (Speicherabzug geschrieben)

+1 for solution 1

[GunChleoc (gunchleoc)]

That assert pointed me in the correct direction. All that needed doing in the end is increasing the area that the map is recalculated

@lowne: Thanks for all those screenshots, they were invaluable :)

The savegame is unrecoverable, so I'm attaching a savegame with an earlier state of the game. Play as red player and delete the small military buildings close to the border, or play as blue and conquer them.

[Klaus Halfmann (klaus-halfmann)]

@lowne I tried to reproduce this in a normal Game with Guns fix applied and found no such Issue as you described it. I used that savegame from Gun and noticed a difference, compared to trunk.
So I think Gun has fixed it.

Lets merge this to trunk now and have many happy stays in widelands :-)

[GunChleoc (gunchleoc)]

Fixed in build20-rc1