Un-reviewed applications from a PPA have 1 star and 1 review

[Rick Spencer]

I noticed this related to Photobomb in an article about Software Center. This obviously puts application developers at a significant disadvantage. I checked MyApps and it also showed that Photobomb was unreviewed. I think the only reason that Photobomb is showing up is that I added it from my PPA, though, in which case, maybe it shouldn't have any stars.

ProblemType: Bug
DistroRelease: Ubuntu 11.10
Package: software-center 4.1.23.4
ProcVersionSignature: Ubuntu 3.0.0-11.18-generic 3.0.4
Uname: Linux 3.0.0-11-generic x86_64
ApportVersion: 1.23-0ubuntu1
Architecture: amd64
Date: Sat Sep 24 10:28:28 2011
InstallationMedia: Ubuntu 11.10 "Oneiric Ocelot" - Beta amd64 (20110919)
PackageArchitecture: all
ProcEnviron:
 PATH=(custom, no user)
 LANG=en_US.UTF-8
 SHELL=/bin/bash
SourcePackage: software-center
UpgradeStatus: No upgrade log present (probably fresh install)

[Matthew Paul Thomas (mpt)]

I am using the Polly PPA but not the Photobomb PPA. Polly is displayed with no reviews or average rating. Photobomb is displayed with one review that rates it one star. Therefore, the problem you're experiencing is unrelated to Photobomb being in a PPA.

That review is from three days ago. You reported this bug two days ago, so when you reported it, it did indeed have one review and one star. Therefore, it's not something USC has against Photobomb either. ;-)

If you still don't see the review, please launch software-center from a terminal, and paste here any error output when you go to the screen for Photobomb. If anything weird shows up in USC, a screenshot might help too. Thanks.

[Matthew Paul Thomas (mpt)]

So the bug is basically that a review from a non-PPA package is also being shown for a PPA package of the same name. That probably shouldn't happen. The easiest way to prevent it from happening is just not to present, or allow, reviews for (non-Purchase) PPA packages at all.

This is semi-related to bug 766951, where reviews for the same package version on a different distribution series are being counted but not shown. In that case, they should be shown.)

[Kiwinote (kiwinote)]

The problem we have here is that the review-stats cache we maintain in s-c is only based on the pkgname, not the origin. This causes the stats for the commercial photobomb to be shown in the listings for the ppa photobomb. For oneiric we can't fix this anymore: the first option would be to look up the origin per app in the list view and only display the stats if it's ubuntu/partners/commercial and hence no stats if it's in a ppa - I tried this, but it gives a massive performance hit on the longer lists so it's not practical. Another option is that we could insure that we only cache the stats for a pkgname if it's origin is ubuntu/partners/commercial (ie at db index time), but this requires some re-engineering that isn't suited for this late in the cycle.

[dino99 (9d9)]

That version is no more maintained