Dash - Dash should not steal mouse events outside of the dash
Bug #857422 reported by
Robert Carr
This bug affects 5 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ayatana Design |
Fix Released
|
High
|
John Lea | ||
| Unity |
Fix Released
|
High
|
Unassigned | ||
| nux (Ubuntu) |
Fix Released
|
High
|
Unassigned | ||
| unity (Ubuntu) |
Fix Released
|
High
|
Unassigned | ||
Bug Description
When clicking outside of the dash, currently dash will steal the mouse event and it will not be received by the application once the dash closes, requiring the user to click again.
This also applies to mouse motion, for example widgets with a prelight effect (such as the chrome tabs) will not prelight when the dash is open.
Probably need to rework the way the input window is handled a bit, or use XShape.
Related branches
lp:~nick-dedekind/unity/lp857422.dash-mouse-steal
- Brandon Schaefer (community): Approve
-
Diff: 948 lines (+329/-111)17 files modifieddash/DashController.cpp (+30/-13)
dash/DashController.h (+4/-5)
dash/DashView.cpp (+5/-0)
dash/DashView.h (+2/-0)
hud/HudAbstractView.h (+3/-1)
hud/HudController.cpp (+42/-11)
hud/HudController.h (+7/-3)
hud/HudView.cpp (+60/-65)
hud/HudView.h (+4/-5)
hud/StandaloneHud.cpp (+1/-4)
plugins/unityshell/src/unityshell.cpp (+45/-3)
plugins/unityshell/src/unityshell.h (+2/-0)
tests/autopilot/unity/emulators/dash.py (+4/-0)
tests/autopilot/unity/tests/test_dash.py (+33/-0)
tests/autopilot/unity/tests/test_hud.py (+32/-0)
tests/test_hud_controller.cpp (+2/-1)
unity-shared/ResizingBaseWindow.h (+53/-0)
| Changed in unity: | |
| assignee: | nobody → Robert Carr (robertcarr) |
| Changed in unity (Ubuntu): | |
| assignee: | nobody → Robert Carr (robertcarr) |
| Changed in nux (Ubuntu): | |
| assignee: | nobody → Robert Carr (robertcarr) |
| Changed in nux: | |
| assignee: | nobody → Robert Carr (robertcarr) |
| Changed in ayatana-design: | |
| assignee: | nobody → John Lea (johnlea) |
| importance: | Undecided → High |
| status: | New → Fix Committed |
| tags: | added: onew udo |
| summary: |
- Dash should not steal mouse events outside of the dash + Dash - Dash should not steal mouse events outside of the dash |
| Changed in nux: | |
| status: | New → Confirmed |
| Changed in unity: | |
| status: | New → Confirmed |
| Changed in nux (Ubuntu): | |
| status: | New → Confirmed |
| Changed in unity (Ubuntu): | |
| status: | New → Confirmed |
Revision history for this message
| Robert Carr (robertcarr) wrote | #1 |
| Changed in ayatana-design: | |
| status: | Fix Committed → Fix Released |
| Changed in unity (Ubuntu): | |
| milestone: | none → later |
| Changed in nux (Ubuntu): | |
| milestone: | none → later |
| Changed in unity: | |
| milestone: | none → backlog |
| Changed in nux: | |
| importance: | Undecided → Medium |
| Changed in unity: | |
| importance: | Undecided → Medium |
| Changed in nux (Ubuntu): | |
| importance: | Undecided → Medium |
| Changed in unity (Ubuntu): | |
| importance: | Undecided → Medium |
| assignee: | Robert Carr (robertcarr) → nobody |
| Changed in nux (Ubuntu): | |
| assignee: | Robert Carr (robertcarr) → nobody |
| Changed in nux: | |
| assignee: | Robert Carr (robertcarr) → nobody |
| Changed in unity: | |
| assignee: | Robert Carr (robertcarr) → nobody |
| tags: | added: udp |
| Changed in ayatana-design: | |
| status: | Fix Released → Fix Committed |
| Changed in ayatana-design: | |
| status: | Fix Committed → Triaged |
| Changed in nux: | |
| assignee: | nobody → Jay Taoko (jaytaoko) |
| Changed in ayatana-design: | |
| status: | Triaged → Fix Committed |
| Changed in unity: | |
| assignee: | nobody → Robert Carr (robertcarr) |
| Changed in ayatana-design: | |
| importance: | High → Critical |
| Changed in unity: | |
| importance: | Medium → High |
Revision history for this message
| Jay Taoko (jaytaoko) wrote | #2 |
| Changed in unity: | |
| importance: | High → Medium |
| assignee: | Robert Carr (robertcarr) → nobody |
| Changed in nux (Ubuntu): | |
| milestone: | later → none |
| Changed in unity (Ubuntu): | |
| milestone: | later → none |
| Changed in ayatana-design: | |
| importance: | Critical → High |
| Changed in unity: | |
| status: | Confirmed → Triaged |
| Changed in nux: | |
| status: | Confirmed → Triaged |
| Changed in unity (Ubuntu): | |
| status: | Confirmed → Triaged |
| Changed in nux (Ubuntu): | |
| status: | Confirmed → Triaged |
| tags: | added: dashm |
| Changed in nux: | |
| importance: | Medium → High |
| Changed in unity: | |
| importance: | Medium → High |
| Changed in nux (Ubuntu): | |
| importance: | Medium → High |
| Changed in unity (Ubuntu): | |
| importance: | Medium → High |
| Changed in unity: | |
| milestone: | backlog → none |
| tags: | added: exbacklog |
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | #3 |
| Changed in unity: | |
| status: | Triaged → Fix Released |
| Changed in ayatana-design: | |
| status: | Fix Committed → Fix Released |
| tags: |
added: reviewedbydesignq removed: dashm udo udp |
| no longer affects: | nux |
| Changed in nux (Ubuntu): | |
| status: | Triaged → Fix Released |
| Changed in unity (Ubuntu): | |
| status: | Triaged → Fix Released |
To post a comment you must log in.
This is not trivial to fix, and a few solutions I have investigated involve messing with Nux API. As it's not a glaring bug, I'm kind of inclined to put this off until next cycle.