history_db plugin causes "bzr tags" to error out if there is a tag pointing to a revision not in the ancestry

[Eli Zaretskii]

Running "bzr tags" in the Emacs repository errors out with this message:

   bzr: ERROR: rev_id {<email address hidden>} not in database

If I use --no-plugins, the problem disappears. I was told that this is a problem with the history_db plugin.

Here's the backtrace:

15.797 Traceback (most recent call last):
  File "bzrlib\commands.pyo", line 946, in exception_to_return_code
  File "bzrlib\commands.pyo", line 1150, in run_bzr
  File "bzrlib\commands.pyo", line 699, in run_argv_aliases
  File "bzrlib\commands.pyo", line 721, in run
  File "bzrlib\cleanup.pyo", line 135, in run_simple
  File "bzrlib\cleanup.pyo", line 165, in _do_with_cleanups
  File "bzrlib\commands.pyo", line 1165, in ignore_pipe
  File "bzrlib\builtins.pyo", line 5631, in run
  File "bzrlib\decorators.pyo", line 154, in read_locked
  File "bzrlib\branch.pyo", line 385, in revision_id_to_dotted_revno
  File "D:/usr/Bazaar/plugins\history_db\__init__.py", line 231, in _history_db_revision_id_to_dotted_revno
  File "D:/usr/Bazaar/plugins\history_db\history_db.py", line 1385, in get_dotted_revnos
BzrError: rev_id {<email address hidden>} not in database

[John A Meinel (jameinel)]

This only happens for branches which have tags which point at revisions that are not in the ancestry.

I think the issue is that "Branch.revision_id_to_dotted_revno('no-such-rev')" raises errors.NoSuchRevision, but history-db's implementation raises errors.BzrError. We just need to match the exception type, and I think the code will work.

[Eli Zaretskii (eliz)]

Any chance of having this fixed in time for bzr 2.5.0? It sounds like the fix is simple.