mdbus2 core dumps on invalid bus name ending with period (.)

Bug #856306 reported by Magnus Ihse Bursie
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
mdbus (Ubuntu)
Fix Released
Undecided
Simon Fels

Bug Description

A simple bug irritating issue. A mistyped bus name should not result in a core dump.

Actual output:

magnusi@sthihse:~$ mdbus2 org.foo.
process 7181: arguments to dbus_message_new_method_call() were incorrect, assertion "destination == NULL || _dbus_check_is_valid_bus_name (destination)" failed in file dbus-message.c line 1201.
This is normally a bug in some application using the D-Bus library.

** ERROR **: Out of memory
aborting...
Aborted (core dumped)
magnusi@sthihse:~$

Expected output:
magnusi@sthihse:~$ mdbus2 org.foo
[ERR]: The name org.foo was not provided by any .service files
/
magnusi@sthihse:~$

ProblemType: Bug
DistroRelease: Ubuntu 11.04
Package: mdbus2 2.0.2-1ubuntu1
ProcVersionSignature: Ubuntu 2.6.38-11.50-generic 2.6.38.8
Uname: Linux 2.6.38-11-generic x86_64
Architecture: amd64
Date: Thu Sep 22 13:16:54 2011
InstallationMedia: Ubuntu 11.04 "Natty Narwhal" - Release amd64 (20110427.1)
SourcePackage: mdbus
UpgradeStatus: No upgrade log present (probably fresh install)

Revision history for this message
Magnus Ihse Bursie (ihse) wrote :
Revision history for this message
Simon Fels (morphis) wrote :

This is already fixed upstream and should be closed with the next upload to Debian.

Changed in mdbus (Ubuntu):
assignee: nobody → morphis (morphis)
Revision history for this message
Simon Fels (morphis) wrote :

Version 2.3.0 of mdbus is already ready for upload here http://anonscm.debian.org/gitweb/?p=pkg-fso/mdbus.git

It just needs a review from the original maintainer.

Changed in mdbus (Ubuntu):
status: New → In Progress
Revision history for this message
Simon Fels (morphis) wrote :

Version 2.3.0 of mdbus is now available in quantal.

Changed in mdbus (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Sebastian Reichel (sre) wrote :

sre@earth ~ % dpkg -l mdbus2
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name Version Architecture Description
+++-====================================-=======================-=======================-==============================================================================
ii mdbus2 2.3.0-3 amd64 DBus introspection command line utility
sre@earth ~ % mdbus2 org.foo.

(mdbus2:6757): GLib-GIO-CRITICAL **: g_dbus_connection_signal_subscribe: assertion `sender == NULL || (g_dbus_is_name (sender) && (connection->flags & G_DBUS_CONNECTION_FLAGS_MESSAGE_BUS_CONNECTION))' failed

(mdbus2:6757): GLib-GIO-CRITICAL **: g_dbus_connection_signal_subscribe: assertion `sender == NULL || (g_dbus_is_name (sender) && (connection->flags & G_DBUS_CONNECTION_FLAGS_MESSAGE_BUS_CONNECTION))' failed

(mdbus2:6757): GLib-GIO-CRITICAL **: g_dbus_message_new_method_call: assertion `name == NULL || g_dbus_is_name (name)' failed

(mdbus2:6757): GLib-GIO-CRITICAL **: g_dbus_message_set_body: assertion `G_IS_DBUS_MESSAGE (message)' failed

(mdbus2:6757): GLib-GIO-CRITICAL **: g_dbus_connection_send_message_with_reply_sync: assertion `G_IS_DBUS_MESSAGE (message)' failed

(mdbus2:6757): GLib-GObject-CRITICAL **: g_object_unref: assertion `G_IS_OBJECT (object)' failed
zsh: segmentation fault mdbus2 org.foo.

Revision history for this message
Simon Fels (morphis) wrote :
Revision history for this message
Simon Fels (morphis) wrote :

New release archives for 2.3.1 are now available at http://downloads.freesmartphone.org/sources/tools/mdbus2/

Revision history for this message
Sebastian Reichel (sre) wrote :

The fix has been released to Ubuntu long time ago.

Changed in mdbus (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.