memory leak in client_list

[Wez Furlong]

I'm writing an svn->hg migration tool which makes relatively heavy use of this function over many revisions and noticed that memory usage was increasing. With the help of the "Instruments" tool on OS/X, I determined that there were two leaks in the success path; one of the temporary apr pool and the other of a reference to the dict created by the list_receiver.

The following patch appears to address the issue, with the caveat that I am not especially familiar with the python guts!

=== modified file 'subvertpy/client.c'
--- subvertpy/client.c 2011-09-18 17:14:02 +0000
+++ subvertpy/client.c 2011-09-18 17:14:06 +0000
@@ -165,6 +165,7 @@
     }

     PyDict_SetItemString(dict, path, value);
+ Py_DECREF(value);

     PyGILState_Release(state);

@@ -1105,6 +1106,7 @@
                                        list_receiver, entry_dict,
                                        client->client, temp_pool));
 #endif
+ apr_pool_destroy(temp_pool);

     return entry_dict;
 }

[Jelmer Vernooij (jelmer)]

Thanks for the patch! Your solution is fine, so I've pushed it to trunk.