widelands

start multiplayer game with all slots closed

Bug #853217 reported by Shevonar
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Medium
Shevonar
widelands build17-rc1

Bug Description

The "Start game" button in multiplayer games is enabled if all slots are closed. That doesn't make sense and will cause an error. I'll fix that bug now but wanted to report it before :)

Tags: multiplayer

Related branches

lp:~shevonar/widelands/feature-random-tribe-and-AI
Widelands Developers: Pending requested
Diff: 33 lines (+8/-4)
2 files modified
src/network/nethost.cc (+4/-2)
src/wlapplication.cc (+4/-2)
Shevonar (shevonar)
Changed in widelands:
assignee: nobody → Shevonar (shevonar)
Shevonar (shevonar)
Changed in widelands:
status: New → In Progress
Revision history for this message
SirVer (sirver) wrote :

Sehvonar, Is your branch ready for merging? I saw that it contains more than just the fix for this bug (which is not a problem, but I do not want unstable stuff in trunk obviously).

Changed in widelands:
importance: Undecided → Medium
status: In Progress → Fix Committed
status: Fix Committed → Confirmed
Revision history for this message
Shevonar (shevonar) wrote :

Well I still hope that the other stuff will also be accepted (would be nice to have another (your) opinion in the merge proposal). Its not a big deal to provide a patch for this bug only if you do not want to merge everything.

Revision history for this message
Hans Joachim Desserud (hjd) wrote :

Merged in r5984.

If possible, it might be better to create separate branches for different issues in the future to be able to review changes independently. (Of course if the issue is tied to the other changes, it wouldn't make sense to split it out). Anyways, well done.

Changed in widelands:
milestone: none → build17-rc1
status: Confirmed → Fix Committed
Revision history for this message
SirVer (sirver) wrote :

Released in build17-rc1.

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.