denial of privileges not reported in SIP patron status field

[Sarah Chodrow]

Evergreen version: at least 2.0.7 through current master.
OpenSRF version: 2.0 and 2.0.1
PostgreSQL version: 8.4, 9.0
Linux distribution: Ubuntu Lucid, Maverick
Test samples: any patron with (bills+fines) > $10.00 (Evergreen default) or with an expired card.

The SIP 24 (patron status) & 64 (patron info) responses do not correctly identify all patrons whose privileges have been denied in the 14 char patron status field (as opposed to the AF screen message field.)

Specifically, {branch}/Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm:charge_ok() is used to set positions 0 (charge privileges denied), 1 (renewal privileges denied) and 3 (hold privileges denied) to Y only when the patron or card is active and not barred; it does not report cases where the patron's fines are too high or the patron card has expired in the patron status field.

My new Patron.pm, with modified charge_ok() is attached below. (Not really good with git yet--Patron.pm pulled from master as of 12 September 2011.)

[Jason Stephenson (jstephenson)]

Sarah, could you add a Developer's Certificate of Origin as a comment on this bug, please?

You can find a template for one here:

http://git.evergreen-ils.org/?p=Evergreen.git;a=blob;f=DCO-1.1.txt;hb=HEAD

In the meantime, I'll make a git branch with your code modifications.

Jason

[Jason Stephenson (jstephenson)]

Branchified:

For sharing lp849447 via the remote repo working:

You need only add the remote once, regardless of how many branches you wish to look at.
To add this repo as working:
 Read-only (git protocol):
  git remote add working git://git.evergreen-ils.org/working/Evergreen
 Read-write (ssh protocol):
  git remote add working <email address hidden>:working/Evergreen

Once you have the remote added you can check out this branch:
git co -b lp849447 working/collab/dyrcona/lp849447

[Jason Stephenson (jstephenson)]

After doing some more looking, I think Sarah's change is a good to go.

The only user penalties retrieved by the SIP code are those that block something: Circ, Hold, or renew. Presently, it seems that Evergreen only applies those that at least block circ. Since that is the case, I'm comfortable adding the pullrequest tag.

[Thomas Berezansky (tsbere)]

Everything seems to work. Pushed to master.

[Galen Charlton (gmc)]

Pushed a trivial stylistic patch to working/Evergreen.git, branch user/gmcharlt/lp849447

[Mike Rylander (mrylander)]

The original patch, and Galen's update, both pulled into master through 2.0. Thanks, Sarah and Galen!