OpenStack Compute (nova)

Direct use of sudo (instead of "run_as_root=True") has crept in code

Bug #847768 reported by Thierry Carrez on 2011-09-12

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Compute (nova)	Fix Released	Medium	Thierry Carrez	OpenStack Compute (nova) 2011.3 "diablo"

Bug Description

Direct usage of "sudo" in utils.execute has been added to code, bypassing the new method of calling elevated privileges (i.e. use the run_as_root=True argument):

Added at rev1477:
./nova/virt/disk.py: utils.execute('sudo', 'tee', metadata_path,

Added at rev1439:
./nova/tests/test_libvirt.py: utils.execute('sudo', 'qemu-img', 'create', '-f', 'raw',
./nova/tests/test_libvirt.py: utils.execute('sudo', 'qemu-img', 'info', '/test/disk.local').\

Related branches

lp:~ttx/nova/lp847768

Merged into lp:~hudson-openstack/nova/milestone-proposed at revision 1167

OpenStack release team: Pending requested 2011-09-13

Merged into lp:~hudson-openstack/nova/trunk at revision 1554

Dan Prince (community): Approve on 2011-09-12

Brian Waldon (community): Approve on 2011-09-12

Thierry Carrez (ttx) on 2011-09-12

Changed in nova:
assignee:	nobody → Thierry Carrez (ttx)
importance:	Undecided → Medium
milestone:	none → 2011.3
status:	New → In Progress

Revision history for this message

Vish Ishaya (vishvananda) wrote on 2011-09-12:

Already got the qemu-img ones here:

https://code.launchpad.net/~vishvananda/nova/lp845753

They shouldn't have been sudo anyway

OpenStack Infra (hudson-openstack) on 2011-09-12

Changed in nova:
status:	In Progress → Fix Committed

Thierry Carrez (ttx) on 2011-09-22

Changed in nova:
status:	Fix Committed → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.