Uses /var/state to store files

Bug #8467 reported by Debian Bug Importer
4
Affects Status Importance Assigned to Milestone
discover (Debian)
Fix Released
Unknown
discover (Ubuntu)
Invalid
High
Unassigned

Bug Description

Automatically imported from Debian bug report #273205 http://bugs.debian.org/273205

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Automatically imported from Debian bug report #273205 http://bugs.debian.org/273205

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-Id: <20040924143126.2F42B10D9BF@localhost>
Date: Fri, 24 Sep 2004 16:31:25 +0200
From: Thomas Hood <email address hidden>
To: Debian Bug Tracking System <email address hidden>
Subject: Uses /var/state to store files

Package: discover
Severity: serious

In /usr/bin/discover-config

    localstatedir="/var"

In /sbin/discover-modprobe

    localstatedir="$(discover-config --localstatedir)"
    crashdir="${localstatedir}/state/discover"

This means that the crash file will be stored under /var/state/. However,
this directory is not recognized by the FHS.

-- System Information:
Debian Release: 3.1
  APT prefers testing
  APT policy: (500, 'testing'), (50, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.8.1
Locale: LANG=en_IE@euro, LC_CTYPE=en_IE@euro

Revision history for this message
Matt Zimmerman (mdz) wrote :

discover belongs in universe; we only need discover1 (for d-i and xfree86)

Revision history for this message
In , GOTO Masanori (gotom-debian) wrote :

> In /usr/bin/discover-config
>
> localstatedir="/var"
>
> In /sbin/discover-modprobe
>
> localstatedir="$(discover-config --localstatedir)"
> crashdir="${localstatedir}/state/discover"
>
> This means that the crash file will be stored under /var/state/. However,
> this directory is not recognized by the FHS.

How about this bug, discover teams?

In FHS 2.x, /var/state was described in FHS, but recent versions do
not mention about /var/state. Instead, use /var/lib. I think
apparently it's easy to switch from /var/state to /var/lib. Is it
hard thing? Or is it just unmaintained package?

Regards,
-- gotom

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-ID: <email address hidden>
Date: Wed, 20 Oct 2004 23:34:20 +0900
From: GOTO Masanori <email address hidden>
To: Discover Workers <email address hidden>,
 Thomas Hood <email address hidden>, <email address hidden>
Cc: <email address hidden>
Subject: Re: Uses /var/state to store files

> In /usr/bin/discover-config
>
> localstatedir="/var"
>
> In /sbin/discover-modprobe
>
> localstatedir="$(discover-config --localstatedir)"
> crashdir="${localstatedir}/state/discover"
>
> This means that the crash file will be stored under /var/state/. However,
> this directory is not recognized by the FHS.

How about this bug, discover teams?

In FHS 2.x, /var/state was described in FHS, but recent versions do
not mention about /var/state. Instead, use /var/lib. I think
apparently it's easy to switch from /var/state to /var/lib. Is it
hard thing? Or is it just unmaintained package?

Regards,
-- gotom

Revision history for this message
In , Javier Fernández-Sanguino (jfs) wrote : Patch (possible NMU?) for these bugs

tags 273205 patch
tags 246046 patch
tags 247423 patch
thanks

The attached (looks good but untested) patch should fix bugs
252634, 273205, 246046, 247423, and 258314 (not an RC bug, but easy to
fix with the patch provided).

I have made discover-modprobe independant from stuff in /usr/bin
(discover-config, cut, and uniq) and also made it FHS compliant (this
should probably have been done with version 1.2-1, as per the changelog).
Hopefully 'Discover Workers' can review this patch and submit a new fixed
package to Debian's queue in order to close some RC bugs... If not, please
ask for a NMU and I will try to review this patch to the best of my ability
and make a NMU for discover.

Thanks

Javier

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-ID: <email address hidden>
Date: Tue, 26 Oct 2004 16:30:45 +0200
From: Javier =?iso-8859-1?Q?Fern=E1ndez-Sanguino_Pe=F1a?= <email address hidden>
To: <email address hidden>, <email address hidden>, <email address hidden>,
 <email address hidden>, <email address hidden>
Cc: <email address hidden>
Subject: Patch (possible NMU?) for these bugs

--a8Wt8u1KmwUX3Y2C
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

tags 273205 patch
tags 246046 patch
tags 247423 patch
thanks

The attached (looks good but untested) patch should fix bugs
252634, 273205, 246046, 247423, and 258314 (not an RC bug, but easy to=20
fix with the patch provided).

I have made discover-modprobe independant from stuff in /usr/bin=20
(discover-config, cut, and uniq) and also made it FHS compliant (this=20
should probably have been done with version 1.2-1, as per the changelog).=
=20
Hopefully 'Discover Workers' can review this patch and submit a new fixed=
=20
package to Debian's queue in order to close some RC bugs... If not, please=
=20
ask for a NMU and I will try to review this patch to the best of my ability=
=20
and make a NMU for discover.

Thanks

Javier

--a8Wt8u1KmwUX3Y2C
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFBfl+Vi4sehJTrj0oRAqv8AJwPZm7a5yvFzj4ytT4DIJiJng8r3ACffvBT
LuhVxDlOqO7TeZz990mLOLo=
=pO7o
-----END PGP SIGNATURE-----

--a8Wt8u1KmwUX3Y2C--

Revision history for this message
In , Ian Murdock (imurdock-progeny) wrote : Re: Bug#246046: Patch (possible NMU?) for these bugs

Hi Javier,

You forgot to attach the patch..

-ian

On Tue, 2004-10-26 at 16:30 +0200, Javier Fernández-Sanguino Peña wrote:
> tags 273205 patch
> tags 246046 patch
> tags 247423 patch
> thanks
>
> The attached (looks good but untested) patch should fix bugs
> 252634, 273205, 246046, 247423, and 258314 (not an RC bug, but easy to
> fix with the patch provided).
>
> I have made discover-modprobe independant from stuff in /usr/bin
> (discover-config, cut, and uniq) and also made it FHS compliant (this
> should probably have been done with version 1.2-1, as per the changelog).
> Hopefully 'Discover Workers' can review this patch and submit a new fixed
> package to Debian's queue in order to close some RC bugs... If not, please
> ask for a NMU and I will try to review this patch to the best of my ability
> and make a NMU for discover.
>
> Thanks
>
> Javier

--
Ian Murdock
317-578-8882 (office)
http://www.progeny.com/
http://ianmurdock.com/

"All men dream: but not equally. Those who dream by night in
the dusty recesses of their minds wake in the day to find that it was
vanity: but the dreamers of the day are dangerous men, for they may
act their dreams with open eyes, to make it possible." -T.E. Lawrence

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-Id: <email address hidden>
Date: Tue, 02 Nov 2004 08:46:57 -0500
From: Ian Murdock <email address hidden>
To: Javier =?ISO-8859-1?Q?Fern=E1ndez-Sanguino_?= =?ISO-8859-1?Q?Pe=F1a?= <email address hidden>,
 <email address hidden>
Cc: <email address hidden>, <email address hidden>,
 <email address hidden>, <email address hidden>
Subject: Re: Bug#246046: Patch (possible NMU?) for these bugs

Hi Javier,

You forgot to attach the patch..

-ian

On Tue, 2004-10-26 at 16:30 +0200, Javier Fern�ez-Sanguino Pe�rote:
> tags 273205 patch
> tags 246046 patch
> tags 247423 patch
> thanks
>
> The attached (looks good but untested) patch should fix bugs
> 252634, 273205, 246046, 247423, and 258314 (not an RC bug, but easy to
> fix with the patch provided).
>
> I have made discover-modprobe independant from stuff in /usr/bin
> (discover-config, cut, and uniq) and also made it FHS compliant (this
> should probably have been done with version 1.2-1, as per the changelog).
> Hopefully 'Discover Workers' can review this patch and submit a new fixed
> package to Debian's queue in order to close some RC bugs... If not, please
> ask for a NMU and I will try to review this patch to the best of my ability
> and make a NMU for discover.
>
> Thanks
>
> Javier

--
Ian Murdock
317-578-8882 (office)
http://www.progeny.com/
http://ianmurdock.com/

"All men dream: but not equally. Those who dream by night in
the dusty recesses of their minds wake in the day to find that it was
vanity: but the dreamers of the day are dangerous men, for they may
act their dreams with open eyes, to make it possible." -T.E. Lawrence

Revision history for this message
In , Javier Fernández-Sanguino (jfs) wrote :

On Tue, Nov 02, 2004 at 08:46:57AM -0500, Ian Murdock wrote:
> Hi Javier,
>
> You forgot to attach the patch..

Aggg... I hate it when it happens. Done now.

Regards

Javier

Revision history for this message
Debian Bug Importer (debzilla) wrote :
Download full text (6.0 KiB)

Message-ID: <email address hidden>
Date: Tue, 2 Nov 2004 21:00:45 +0100
From: Javier =?iso-8859-1?Q?Fern=E1ndez-Sanguino_Pe=F1a?= <email address hidden>
To: Ian Murdock <email address hidden>
Cc: <email address hidden>, <email address hidden>, <email address hidden>,
 <email address hidden>, <email address hidden>
Subject: Re: Bug#246046: Patch (possible NMU?) for these bugs

--4jXrM3lyYWu4nBt5
Content-Type: multipart/mixed; boundary="gj572EiMnwbLXET9"
Content-Disposition: inline

--gj572EiMnwbLXET9
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Nov 02, 2004 at 08:46:57AM -0500, Ian Murdock wrote:
> Hi Javier,
>=20
> You forgot to attach the patch..

Aggg... I hate it when it happens. Done now.

Regards

Javier

--gj572EiMnwbLXET9
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="discover-bugfixes.diff"
Content-Transfer-Encoding: quoted-printable

diff -Nru discover-2.0.4.old/debian/changelog discover-2.0.4/debian/changel=
og
--- discover-2.0.4.old/debian/changelog 2004-10-26 16:17:35.000000000 +0200
+++ discover-2.0.4/debian/changelog 2004-10-26 16:23:58.000000000 +0200
@@ -1,3 +1,20 @@
+discover (2.0.4-6) unstable; urgency=3Dlow
+
+ * Remove discover init.d symlinks only on purge (Closes: #252634)=20
+ [discover-modprobe]
+ * Modify to migrate from /var/state to /var/lib per FHS
+ this should have been done when closing #136992 (Closes: #273205)
+ * Have the script use sane defaults if discover-config is not
+ available (Closes: #246046)
+ * Use cat+sed instead of cut+grep
+ * Use uniq only if available, and, in any case, keep a record of modules
+ that were loaded so that it does not attempt to load modules twice
+ * The above changes makes the script independent from /usr/bin/=20
+ (Closes: #247423)
+ * Make the script POSIX compliant (Closes: #258314)
+
+ -- Javier Fernandez-Sanguino Pen~a <email address hidden> Tue, 26 Oct 2004 1=
5:41:24 +0200
+
 discover (2.0.4-5) unstable; urgency=3Dlow
=20
   * The busclass change read too much PCI data, and with some devices
diff -Nru discover-2.0.4.old/debian/discover.postrm discover-2.0.4/debian/d=
iscover.postrm
--- discover-2.0.4.old/debian/discover.postrm 2004-04-09 19:45:05.000000000=
 +0200
+++ discover-2.0.4/debian/discover.postrm 2004-10-26 15:41:19.000000000 +02=
00
@@ -26,11 +26,8 @@
=20
 CONFFILE=3D/etc/discover.conf
=20
-if [ "$1" =3D "remove" ]; then
- update-rc.d discover remove > /dev/null 2>&1
-fi
-
 if [ "$1" =3D "purge" ]; then
+ update-rc.d -f discover remove > /dev/null 2>&1
   rm -f $CONFFILE
 fi
=20
diff -Nru discover-2.0.4.old/doc/crash-snippet.xml discover-2.0.4/doc/crash=
-snippet.xml
--- discover-2.0.4.old/doc/crash-snippet.xml 2004-04-09 19:45:08.000000000 =
+0200
+++ discover-2.0.4/doc/crash-snippet.xml 2004-10-26 15:42:56.000000000 +0200
@@ -23,7 +23,7 @@
 -->
=20
 <varlistentry>
- <term><filename>&localstatedir;/state/discover/crash</filename></term>
+ <term><filename>&localstatedir;/lib/discover/crash</filename></term>
   <listitem>
     <para>A crash file written and erased each time
     <command>discover-modprobe</co...

Read more...

Revision history for this message
In , Thomas Hood (jdthood-aglu) wrote : fixed in svn

This has been fixed by Ian Murdoch in the svn archive.

--
Thomas Hood

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-Id: <1099742225.3654.491.camel@thanatos>
Date: Sat, 06 Nov 2004 12:57:06 +0100
From: Thomas Hood <email address hidden>
To: <email address hidden>
Subject: fixed in svn

This has been fixed by Ian Murdoch in the svn archive.

--
Thomas Hood

Revision history for this message
In , Thomas Hood (jdthood-aglu) wrote : pending

tags 252634 pending
tags 273205 pending
tags 255868 pending
tags 246046 pending
tags 247423 pending
tags 246045 pending
thanks

Progeny has fixed these in svn and promises a new release RSN.

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-Id: <1100076577.3654.803.camel@thanatos>
Date: Wed, 10 Nov 2004 09:49:38 +0100
From: Thomas Hood <email address hidden>
To: <email address hidden>
Subject: pending

tags 252634 pending
tags 273205 pending
tags 255868 pending
tags 246046 pending
tags 247423 pending
tags 246045 pending
thanks

Progeny has fixed these in svn and promises a new release RSN.

Revision history for this message
In , Javier Fernández-Sanguino (jfs) wrote : Revised patch for these bugs

I have revised the patch I produced after some local testing. First, some
points:

1.- discover is located in /bin but is linked to libraries in /usr/lib
2.- discover's init is run in S36 which is just after S35mountall. So /usr
should be available at that point.

In any case, I have made discover-modprobe independant from /usr (in the
sense that it will not spout errors if it's not available but it won't load
anything either since discover cannot be run). So it might just be that
#247423 only applies to woody systems really.

IMHO /bin/discover should be relocated to /usr/bin/discover and the init.d
script should only be run if it's available. Maybe discover-modprobe should
be moved there too.

Also notice I have fixed a logic failure in the script that made it try to
load modules even if they have been previously loaded (even if the
changelog said otherwise)

Regards

Javier

Revision history for this message
In , Javier Fernández-Sanguino (jfs) wrote :

And again, I'm missing the patch. Here it is.

Javier

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-ID: <email address hidden>
Date: Tue, 16 Nov 2004 01:41:42 +0100
From: Javier =?iso-8859-1?Q?Fern=E1ndez-Sanguino_Pe=F1a?= <email address hidden>
To: <email address hidden>, <email address hidden>, <email address hidden>,
 <email address hidden>, <email address hidden>
Subject: Revised patch for these bugs

--RnlQjJ0d97Da+TV1
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

I have revised the patch I produced after some local testing. First, some=
=20
points:

1.- discover is located in /bin but is linked to libraries in /usr/lib
2.- discover's init is run in S36 which is just after S35mountall. So /usr=
=20
should be available at that point.

In any case, I have made discover-modprobe independant from /usr (in the=20
sense that it will not spout errors if it's not available but it won't load=
=20
anything either since discover cannot be run). So it might just be that=20
#247423 only applies to woody systems really.

IMHO /bin/discover should be relocated to /usr/bin/discover and the init.d=
=20
script should only be run if it's available. Maybe discover-modprobe should=
=20
be moved there too.

Also notice I have fixed a logic failure in the script that made it try to=
=20
load modules even if they have been previously loaded (even if the=20
changelog said otherwise)

Regards

Javier

--RnlQjJ0d97Da+TV1
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFBmUzGi4sehJTrj0oRAuJEAKDP5DZUkWaW4W7ki1y79kqskBmdIwCg2sPU
QB3JEmMfWiDDrsvOYr9Wsog=
=R7mG
-----END PGP SIGNATURE-----

--RnlQjJ0d97Da+TV1--

Revision history for this message
Debian Bug Importer (debzilla) wrote :
Download full text (6.0 KiB)

Message-ID: <email address hidden>
Date: Tue, 16 Nov 2004 01:42:40 +0100
From: Javier =?iso-8859-1?Q?Fern=E1ndez-Sanguino_Pe=F1a?= <email address hidden>
To: Javier =?iso-8859-1?Q?Fern=E1ndez-Sanguino_Pe=F1a?= <email address hidden>
Cc: <email address hidden>, <email address hidden>, <email address hidden>,
 <email address hidden>, <email address hidden>
Subject: Re: Revised patch for these bugs

--PmA2V3Z32TCmWXqI
Content-Type: multipart/mixed; boundary="ZGiS0Q5IWpPtfppv"
Content-Disposition: inline

--ZGiS0Q5IWpPtfppv
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

And again, I'm missing the patch. Here it is.

Javier

--ZGiS0Q5IWpPtfppv
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="discover-bugfixes.diff"
Content-Transfer-Encoding: quoted-printable

diff -Nru discover-2.0.4.old/debian/changelog discover-2.0.4/debian/changel=
og
--- discover-2.0.4.old/debian/changelog 2004-10-26 16:17:35.000000000 +0200
+++ discover-2.0.4/debian/changelog 2004-11-16 01:27:15.000000000 +0100
@@ -1,3 +1,22 @@
+discover (2.0.4-5.1) unstable; urgency=3Dlow
+
+ * Remove discover init.d symlinks only on purge (Closes: #252634)=20
+ [Changes to discover-modprobe]
+ * Modify to migrate from /var/state to /var/lib per FHS
+ this should have been done when closing #136992 (Closes: #273205)
+ * Makes the script independent from /usr/bin/ (Closes: #247423)
+ - Use cat+sed instead of cut+grep
+ - Use uniq (and discover) only if /usr/bin/ is available
+ NOTE: Shouldn't discover be relocated to /usr/bin ? it is linked
+ against libraries that are in /usr/lib/ !
+ * Have the script use sane defaults if discover-config is not
+ available (Closes: #246046)
+ * Keep a record of modules that were loaded so that it does not attempt =
to
+ load modules twice
+ * Make the script POSIX compliant (Closes: #258314)
+
+ -- Javier Fernandez-Sanguino Pen~a <email address hidden> Tue, 26 Oct 2004 1=
5:41:24 +0200
+
 discover (2.0.4-5) unstable; urgency=3Dlow
=20
   * The busclass change read too much PCI data, and with some devices
diff -Nru discover-2.0.4.old/debian/discover.postrm discover-2.0.4/debian/d=
iscover.postrm
--- discover-2.0.4.old/debian/discover.postrm 2004-04-09 19:45:05.000000000=
 +0200
+++ discover-2.0.4/debian/discover.postrm 2004-10-26 15:41:19.000000000 +02=
00
@@ -26,11 +26,8 @@
=20
 CONFFILE=3D/etc/discover.conf
=20
-if [ "$1" =3D "remove" ]; then
- update-rc.d discover remove > /dev/null 2>&1
-fi
-
 if [ "$1" =3D "purge" ]; then
+ update-rc.d -f discover remove > /dev/null 2>&1
   rm -f $CONFFILE
 fi
=20
diff -Nru discover-2.0.4.old/doc/crash-snippet.xml discover-2.0.4/doc/crash=
-snippet.xml
--- discover-2.0.4.old/doc/crash-snippet.xml 2004-04-09 19:45:08.000000000 =
+0200
+++ discover-2.0.4/doc/crash-snippet.xml 2004-10-26 15:42:56.000000000 +0200
@@ -23,7 +23,7 @@
 -->
=20
 <varlistentry>
- <term><filename>&localstatedir;/state/discover/crash</filename></term>
+ <term><filename>&localstatedir;/lib/discover/crash</filename></term>
   <listitem>
     <para>A crash file written and erased each time
     <command>discover-modprobe</command> attempts to load a
...

Read more...

Revision history for this message
In , Thomas Hood (jdthood-aglu) wrote : perhaps not pending after all

tags 252634 - pending
tags 273205 - pending
thanks

Revision history for this message
In , Thomas Hood (jdthood-aglu) wrote :

tags 255868 - pending
tags 246046 - pending
tags 247423 - pending
tags 246045 - pending
tags 252634 fixed-upstream
tags 273205 fixed-upstream
tags 255868 fixed-upstream
tags 246046 fixed-upstream
tags 247423 fixed-upstream
tags 246045 fixed-upstream
thanks

Revision history for this message
In , Thomas Hood (jdthood-aglu) wrote : /usr/ only usable after S:S45mountnfs.sh

Javier Fernández-Sanguino Peña wrote:
> 1.- discover is located in /bin but is linked to libraries in /usr/lib
[...]
> IMHO /bin/discover should be relocated to /usr/bin/discover and the
> init.d script should only be run if [discover is] available.

I agree, unless there is something that discover can still do without
all those libraries.

> 2.- discover's init is run in S36 which is just after S35mountall. So /usr
> should be available at that point.

One should only expect /usr/ to be available after S:S45mountnfs.sh.
Discover's initscript runs at S:S36discover.

--
Thomas Hood

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-Id: <1100615933.20956.433.camel@thanatos>
Date: Tue, 16 Nov 2004 15:38:53 +0100
From: Thomas Hood <email address hidden>
To: <email address hidden>
Subject: perhaps not pending after all

tags 252634 - pending
tags 273205 - pending
thanks

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-Id: <1100616176.20956.441.camel@thanatos>
Date: Tue, 16 Nov 2004 15:42:57 +0100
From: Thomas Hood <email address hidden>
To: <email address hidden>
Subject: perhaps not pending after all

tags 255868 - pending
tags 246046 - pending
tags 247423 - pending
tags 246045 - pending
tags 252634 fixed-upstream
tags 273205 fixed-upstream
tags 255868 fixed-upstream
tags 246046 fixed-upstream
tags 247423 fixed-upstream
tags 246045 fixed-upstream
thanks

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-Id: <1100617746.20956.467.camel@thanatos>
Date: Tue, 16 Nov 2004 16:09:07 +0100
From: Thomas Hood <email address hidden>
To: Discover Workers <email address hidden>
Cc: <email address hidden>, <email address hidden>,
 <email address hidden>, <email address hidden>, <email address hidden>
Subject: /usr/ only usable after S:S45mountnfs.sh

Javier Fern=E1ndez-Sanguino Pe=F1a wrote:
> 1.- discover is located in /bin but is linked to libraries in /usr/lib
[...]
> IMHO /bin/discover should be relocated to /usr/bin/discover and the
> init.d script should only be run if [discover is] available.

I agree, unless there is something that discover can still do without
all those libraries.

> 2.- discover's init is run in S36 which is just after S35mountall. So /=
usr=20
> should be available at that point.

One should only expect /usr/ to be available after S:S45mountnfs.sh.=20
Discover's initscript runs at S:S36discover.

--=20
Thomas Hood

Revision history for this message
In , Jeff Licquia (licquia) wrote : Bug#273205: fixed in discover 2.0.6-1
Download full text (4.5 KiB)

Source: discover
Source-Version: 2.0.6-1

We believe that the bug you reported is fixed in the latest version of
discover, which is due to be installed in the Debian FTP archive:

discover-udeb_2.0.6-1_i386.udeb
  to pool/main/d/discover/discover-udeb_2.0.6-1_i386.udeb
discover_2.0.6-1.diff.gz
  to pool/main/d/discover/discover_2.0.6-1.diff.gz
discover_2.0.6-1.dsc
  to pool/main/d/discover/discover_2.0.6-1.dsc
discover_2.0.6-1_i386.deb
  to pool/main/d/discover/discover_2.0.6-1_i386.deb
discover_2.0.6.orig.tar.gz
  to pool/main/d/discover/discover_2.0.6.orig.tar.gz
libdiscover-dev_2.0.6-1_i386.deb
  to pool/main/d/discover/libdiscover-dev_2.0.6-1_i386.deb
libdiscover2_2.0.6-1_i386.deb
  to pool/main/d/discover/libdiscover2_2.0.6-1_i386.deb

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to <email address hidden>,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jeff Licquia <email address hidden> (supplier of updated discover package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing <email address hidden>)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Fri, 19 Nov 2004 15:52:22 -0500
Source: discover
Binary: discover-udeb libdiscover2 discover libdiscover-dev
Architecture: source i386
Version: 2.0.6-1
Distribution: unstable
Urgency: low
Maintainer: Discover Workers <email address hidden>
Changed-By: Jeff Licquia <email address hidden>
Description:
 discover - hardware identification system
 discover-udeb - hardware identification system (udeb) (udeb)
 libdiscover-dev - hardware identification library development files
 libdiscover2 - hardware identification library
Closes: 252634 255868 256473 260205 273205
Changes:
 discover (2.0.6-1) unstable; urgency=low
 .
   * Ian Murdock <email address hidden>:
 .
   * Call update-rc.d remove in postrm on purge, not remove.
     Closes: #252634.
 .
   * Use /var/lib for crash data rather than /var/state, as per FHS.
     Closes: #273205.
 .
   * Allow data query operations (i.e., --data-path and
     --data-version) even when the device type is not specified.
     This mirrors the default behavior of Discover in version 1 and
     is consistent with the results of invoking Discover without
     any arguments (which displays a summary of all device detected).
 .
   * discover-modprobe.conf: Specify the empty string for types, so the
     default behavior is to report on all detected hardware.
 .
   * Allow data query operations (i.e., --data-path and
     --data-version) to take a device ID (that is, a vendor ID and a
     model ID concatenated together, e.g., "0x05af080a") in addition to a
     device type. This is in preparation for adding hotplug support.
 .
   * sysdeps/linux/pci.c: Convert device class to little-endian
     byte order on big-endian architectures. Patch
     from Rafael Espíndola <rafael.espindola at ic.unicamp.br>.
     Closes: #255868.
 ...

Read more...

Revision history for this message
Debian Bug Importer (debzilla) wrote :
Download full text (4.7 KiB)

Message-Id: <email address hidden>
Date: Tue, 23 Nov 2004 01:02:03 -0500
From: Jeff Licquia <email address hidden>
To: <email address hidden>
Subject: Bug#273205: fixed in discover 2.0.6-1

Source: discover
Source-Version: 2.0.6-1

We believe that the bug you reported is fixed in the latest version of
discover, which is due to be installed in the Debian FTP archive:

discover-udeb_2.0.6-1_i386.udeb
  to pool/main/d/discover/discover-udeb_2.0.6-1_i386.udeb
discover_2.0.6-1.diff.gz
  to pool/main/d/discover/discover_2.0.6-1.diff.gz
discover_2.0.6-1.dsc
  to pool/main/d/discover/discover_2.0.6-1.dsc
discover_2.0.6-1_i386.deb
  to pool/main/d/discover/discover_2.0.6-1_i386.deb
discover_2.0.6.orig.tar.gz
  to pool/main/d/discover/discover_2.0.6.orig.tar.gz
libdiscover-dev_2.0.6-1_i386.deb
  to pool/main/d/discover/libdiscover-dev_2.0.6-1_i386.deb
libdiscover2_2.0.6-1_i386.deb
  to pool/main/d/discover/libdiscover2_2.0.6-1_i386.deb

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to <email address hidden>,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jeff Licquia <email address hidden> (supplier of updated discover package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing <email address hidden>)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Fri, 19 Nov 2004 15:52:22 -0500
Source: discover
Binary: discover-udeb libdiscover2 discover libdiscover-dev
Architecture: source i386
Version: 2.0.6-1
Distribution: unstable
Urgency: low
Maintainer: Discover Workers <email address hidden>
Changed-By: Jeff Licquia <email address hidden>
Description:
 discover - hardware identification system
 discover-udeb - hardware identification system (udeb) (udeb)
 libdiscover-dev - hardware identification library development files
 libdiscover2 - hardware identification library
Closes: 252634 255868 256473 260205 273205
Changes:
 discover (2.0.6-1) unstable; urgency=low
 .
   * Ian Murdock <email address hidden>:
 .
   * Call update-rc.d remove in postrm on purge, not remove.
     Closes: #252634.
 .
   * Use /var/lib for crash data rather than /var/state, as per FHS.
     Closes: #273205.
 .
   * Allow data query operations (i.e., --data-path and
     --data-version) even when the device type is not specified.
     This mirrors the default behavior of Discover in version 1 and
     is consistent with the results of invoking Discover without
     any arguments (which displays a summary of all device detected).
 .
   * discover-modprobe.conf: Specify the empty string for types, so the
     default behavior is to report on all detected hardware.
 .
   * Allow data query operations (i.e., --data-path and
     --data-version) to take a device ID (that is, a vendor ID and a
     model ID concatenated together, e.g., "0x05af080a") in addition to a
     device type. This is in preparation for adding hotplug supp...

Read more...

Revision history for this message
In , Javier Fernández-Sanguino (jfs) wrote : Fix pending in documentation files

reopen 273205
severity 273205 minor
tags 273025 - fixed-upstream
retitle 273205 Document directs read to /var/state
thanks

The documentation has not been adjusted to reflect the move from /var/state
to /var/lib, in the patch I provided I did the following:

--- discover-2.0.4.old/doc/crash-snippet.xml 2004-04-09 19:45:08.000000000 +0200
+++ discover-2.0.4/doc/crash-snippet.xml 2004-10-26 15:42:56.000000000 +0200
@@ -23,7 +23,7 @@
 -->

 <varlistentry>
- <term><filename>&localstatedir;/state/discover/crash</filename></term>
+ <term><filename>&localstatedir;/lib/discover/crash</filename></term>
   <listitem>
     <para>A crash file written and erased each time
     <command>discover-modprobe</command> attempts to load a

--

Please consider fixing that too in the next upload.

Regards

Javier

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-ID: <email address hidden>
Date: Mon, 29 Nov 2004 17:57:28 +0100
From: Javier =?iso-8859-1?Q?Fern=E1ndez-Sanguino_Pe=F1a?= <email address hidden>
To: <email address hidden>, <email address hidden>
Subject: Fix pending in documentation files

--+pHx0qQiF2pBVqBT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

reopen 273205
severity 273205 minor
tags 273025 - fixed-upstream
retitle 273205 Document directs read to /var/state
thanks

The documentation has not been adjusted to reflect the move from /var/state=
=20
to /var/lib, in the patch I provided I did the following:

--- discover-2.0.4.old/doc/crash-snippet.xml 2004-04-09 19:45:08.0000000=
00 +0200
+++ discover-2.0.4/doc/crash-snippet.xml 2004-10-26 15:42:56.0000000=
00 +0200
@@ -23,7 +23,7 @@
 -->

 <varlistentry>
- <term><filename>&localstatedir;/state/discover/crash</filename></term>
+ <term><filename>&localstatedir;/lib/discover/crash</filename></term>
   <listitem>
     <para>A crash file written and erased each time
     <command>discover-modprobe</command> attempts to load a

--=20

Please consider fixing that too in the next upload.

Regards

Javier

--+pHx0qQiF2pBVqBT
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFBq1T3i4sehJTrj0oRAui4AJwI9b15Fmb/6vbiyMWwUCN62zjXegCfSnPg
BeSkjbm6+SHYzKFVAC2TKo8=
=AdYl
-----END PGP SIGNATURE-----

--+pHx0qQiF2pBVqBT--

Revision history for this message
In , Thomas Hood (jdthood-yahoo) wrote : tagging 273205, submitter 273205

# Automatically generated email from bts, devscripts version 2.8.5
tags 273205 - fixed-upstream
submitter 273205 <email address hidden>

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-Id: <20041129185436.747A610D635@localhost>
Date: Mon, 29 Nov 2004 19:54:36 +0100
From: Thomas Hood <email address hidden>
To: <email address hidden>
Subject: tagging 273205, submitter 273205

# Automatically generated email from bts, devscripts version 2.8.5
tags 273205 - fixed-upstream
submitter 273205 <email address hidden>

Revision history for this message
In , Thomas Hood (jdthood-aglu) wrote : Bug still present in 2.0.6-2

Doc bugs still present in discover 2.0.6-2:

discover(1):
       /usr/share/list.xml -> /lib/discover/list.xml ?

discover-modprobe.conf(5):
       /usr/local/var/state/discover/crash -> /var/lib/discover/crash

discover-modprobe(8):
       /usr/local/var/state/discover/crash -> /var/lib/discover/crash

It should be noted too that the don't-crash-again feature only works on
systems that have a locally mounted /var/ (or on systems that mount
/var/ prior to S:S36discover; normally network filesystems are mounted
at S:S45mountnfs.sh).

--
Thomas Hood

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-Id: <1101814069.11610.11.camel@thanatos>
Date: Tue, 30 Nov 2004 12:27:50 +0100
From: Thomas Hood <email address hidden>
To: <email address hidden>, <email address hidden>
Subject: Bug still present in 2.0.6-2

Doc bugs still present in discover 2.0.6-2:

discover(1):
       /usr/share/list.xml -> /lib/discover/list.xml ?

discover-modprobe.conf(5):
       /usr/local/var/state/discover/crash -> /var/lib/discover/crash

discover-modprobe(8):
       /usr/local/var/state/discover/crash -> /var/lib/discover/crash

It should be noted too that the don't-crash-again feature only works on
systems that have a locally mounted /var/ (or on systems that mount
/var/ prior to S:S36discover; normally network filesystems are mounted
at S:S45mountnfs.sh).

--
Thomas Hood

Revision history for this message
In , Jeff Licquia (licquia) wrote : Bug#273205: fixed in discover 2.0.7-1
Download full text (3.9 KiB)

Source: discover
Source-Version: 2.0.7-1

We believe that the bug you reported is fixed in the latest version of
discover, which is due to be installed in the Debian FTP archive:

discover-udeb_2.0.7-1_i386.udeb
  to pool/main/d/discover/discover-udeb_2.0.7-1_i386.udeb
discover_2.0.7-1.diff.gz
  to pool/main/d/discover/discover_2.0.7-1.diff.gz
discover_2.0.7-1.dsc
  to pool/main/d/discover/discover_2.0.7-1.dsc
discover_2.0.7-1_i386.deb
  to pool/main/d/discover/discover_2.0.7-1_i386.deb
discover_2.0.7.orig.tar.gz
  to pool/main/d/discover/discover_2.0.7.orig.tar.gz
libdiscover-dev_2.0.7-1_i386.deb
  to pool/main/d/discover/libdiscover-dev_2.0.7-1_i386.deb
libdiscover2_2.0.7-1_i386.deb
  to pool/main/d/discover/libdiscover2_2.0.7-1_i386.deb

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to <email address hidden>,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jeff Licquia <email address hidden> (supplier of updated discover package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing <email address hidden>)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sun, 6 Feb 2005 15:14:22 -0500
Source: discover
Binary: discover-udeb libdiscover2 discover libdiscover-dev
Architecture: source i386
Version: 2.0.7-1
Distribution: unstable
Urgency: low
Maintainer: Discover Workers <email address hidden>
Changed-By: Jeff Licquia <email address hidden>
Description:
 discover - hardware identification system
 discover-udeb - hardware identification system (udeb) (udeb)
 libdiscover-dev - hardware identification library development files
 libdiscover2 - hardware identification library
Closes: 247546 258314 273205 279462 286552 287189
Changes:
 discover (2.0.7-1) unstable; urgency=low
 .
   * Apply patches from Rafael Avila de Espindola (rafael.espindola
     at gmail dot com) to fix some memory leaks.
   * Inspired by Rafael: handle /proc more safely in Linux ATA sysdeps.
   * Inspired by Rafael: check that we could open the configuration
     directory, and close it when we're done.
   * Apply include file fixes to the test suite.
   * Disable curl support in the Debian packages. Closes: #279462.
   * Purge -o from tests and use grep -E instead of egrep.
     Closes: #258314.
   * Fix wrong paths in documentation. Closes: #273205.
   * Fix discover-config documentation to match the utility
     (actually a fix to buildtools). Closes: #247546.
   * Include string.h in sysdeps/linux/ata.c, so we don't get
     weird pointer arithmetic going.
   * Make sure that our device ordering matches whether we read
     PCI device info from /proc or /sys. Closes: #286552.
   * Trimmed unneeded Build-Depends.
   * Fix package build issues with static linking and stripping
     of binaries.
   * Make discover-static /sbin/discover, and get rid of the
     dynamically-linked /usr/bin/discover. Closes: #287189.
   * Update the do...

Read more...

Revision history for this message
Debian Bug Importer (debzilla) wrote :
Download full text (4.1 KiB)

Message-Id: <email address hidden>
Date: Mon, 07 Feb 2005 02:47:12 -0500
From: Jeff Licquia <email address hidden>
To: <email address hidden>
Subject: Bug#273205: fixed in discover 2.0.7-1

Source: discover
Source-Version: 2.0.7-1

We believe that the bug you reported is fixed in the latest version of
discover, which is due to be installed in the Debian FTP archive:

discover-udeb_2.0.7-1_i386.udeb
  to pool/main/d/discover/discover-udeb_2.0.7-1_i386.udeb
discover_2.0.7-1.diff.gz
  to pool/main/d/discover/discover_2.0.7-1.diff.gz
discover_2.0.7-1.dsc
  to pool/main/d/discover/discover_2.0.7-1.dsc
discover_2.0.7-1_i386.deb
  to pool/main/d/discover/discover_2.0.7-1_i386.deb
discover_2.0.7.orig.tar.gz
  to pool/main/d/discover/discover_2.0.7.orig.tar.gz
libdiscover-dev_2.0.7-1_i386.deb
  to pool/main/d/discover/libdiscover-dev_2.0.7-1_i386.deb
libdiscover2_2.0.7-1_i386.deb
  to pool/main/d/discover/libdiscover2_2.0.7-1_i386.deb

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to <email address hidden>,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jeff Licquia <email address hidden> (supplier of updated discover package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing <email address hidden>)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sun, 6 Feb 2005 15:14:22 -0500
Source: discover
Binary: discover-udeb libdiscover2 discover libdiscover-dev
Architecture: source i386
Version: 2.0.7-1
Distribution: unstable
Urgency: low
Maintainer: Discover Workers <email address hidden>
Changed-By: Jeff Licquia <email address hidden>
Description:
 discover - hardware identification system
 discover-udeb - hardware identification system (udeb) (udeb)
 libdiscover-dev - hardware identification library development files
 libdiscover2 - hardware identification library
Closes: 247546 258314 273205 279462 286552 287189
Changes:
 discover (2.0.7-1) unstable; urgency=low
 .
   * Apply patches from Rafael Avila de Espindola (rafael.espindola
     at gmail dot com) to fix some memory leaks.
   * Inspired by Rafael: handle /proc more safely in Linux ATA sysdeps.
   * Inspired by Rafael: check that we could open the configuration
     directory, and close it when we're done.
   * Apply include file fixes to the test suite.
   * Disable curl support in the Debian packages. Closes: #279462.
   * Purge -o from tests and use grep -E instead of egrep.
     Closes: #258314.
   * Fix wrong paths in documentation. Closes: #273205.
   * Fix discover-config documentation to match the utility
     (actually a fix to buildtools). Closes: #247546.
   * Include string.h in sysdeps/linux/ata.c, so we don't get
     weird pointer arithmetic going.
   * Make sure that our device ordering matches whether we read
     PCI device info from /proc or /sys. Closes: #286552.
   * Trimmed unneeded Build-Depends.
   * Fix pa...

Read more...

Changed in discover:
status: Unknown → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.