old c-style functions in common.cpp
Bug #846069 reported by
Aron Boyette
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| New Real Time Battle |
Won't Fix
|
Wishlist
|
Unassigned | ||
Bug Description
~/common/
changecase
upcase
downcase
gsub
split
trim
The components that call these functions should be modified to call the corresponding methods in the latest string class (which I think is part of STL, but I'm not sure). Afterwards, these functions should perhaps be removed from common.cpp altogether.
| Changed in nrtb: | |
| status: | New → Triaged |
| importance: | Low → Wishlist |
| tags: | added: beta cleanup |
Revision history for this message
| Rick Stovall (fpstovall) wrote | #1 |
| Changed in nrtb: | |
| status: | Triaged → Won't Fix |
To post a comment you must log in.
The nrtb::tcp_socket and the nrtb::conf_reader are the primary users of the functions listed above.
Oh and for the record these are NOT "C style" functions.. they are in modern in both design and operation. They are type-safe, throw if they have a problem, do not return status flags and use modern syntax and the STL. They are free-standing functions, but that's the only only similarity to classic "C" functions; they would not even compile in C.
So there! :)