Plans title link not working

Bug #845534 reported by Kevin Lawrence
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Richard Mansfield

Bug Description

When a Plan is inserted into a page the Title of a task is suppposed to be a link to expand to show the detail of the task. It does not do this instead it opens up the users list of pages. This is also the same for the CPD plugin in which exactly the same thing happens. It appears that this is only the case for IE 8 & 9. When I try this in Firefox it all works properly.
Using Mahara 1.4.0, this wasn't a problem in 1.3
Operating system Linux
Database MySQL
IE 8 & 9

Tags: ie
Revision history for this message
François Marier (fmarier) wrote :

For some reason, this works on IE6.

Note that the clickable link is only visible when a description has been provided for a task.

Changed in mahara:
status: New → Triaged
milestone: none → 1.5.0
importance: Undecided → Medium
importance: Medium → Low
tags: added: ie
Revision history for this message
Kevin Lawrence (klawrenceym) wrote :

I have noticed that if you add a plan or CPD to the Dashboard page then it works correctley, i.e. when the title is clicked on it expands to show the description of the task. However, when the plan is inserted into a page it does not work as it should

Revision history for this message
Melissa Draper (melissa) wrote :

Hi Kevin,

Just trying to confirm the issue. I've not noticed anything quite so dramatic as being taken back to the list of pages. However I do notice that if you click a task link after adding the block to a page, the first (and only the first) click on a task title will return you to the first of the tabs block type tabs (the general tab is where plan blocks are and the external content tab is the first tab, and that's where you get returned to.)

Is this what you're describing above?

I haven't been able to test this on IE 8 or 9 yet. Will try to track something down tomorrow and see if it throws me further than just some tabs.

Thanks,
Melissa.

Revision history for this message
Melissa Draper (melissa) wrote :

Ok, I've found an install of ie9 and it does indeed have a fit and go back to the list of pages.

Melissa Draper (melissa)
Changed in mahara:
assignee: nobody → Melissa Draper (melissa)
status: Triaged → In Progress
Melissa Draper (melissa)
Changed in mahara:
milestone: 1.5.0 → 1.4.1
importance: Low → Medium
Revision history for this message
Melissa Draper (melissa) wrote :

https://reviews.mahara.org/#change,795 has been pushed up for this.

Revision history for this message
Melissa Draper (melissa) wrote :

I haven't pushed a change for master yet. We may want to discuss whether it's preferable to rewrite the plans block which would be inappropriate for a 1.4.1 change.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/798
Committed: http://gitorious.org/mahara/mahara/commit/7103c383a0172e114c98182cb4f1eb1c4e2b17cb
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit 7103c383a0172e114c98182cb4f1eb1c4e2b17cb
Author: Richard Mansfield <email address hidden>
Date: Tue Oct 25 17:32:23 2011 +1300

    Eval js to rewrite task titles after block configuration (bug #845534)

    When a plans block is first added to the page, the javascript overlay of
    the task titles was not evaluated. This is fixed by moving javascript
    functions for the plans block into a new javascript file and pulling the
    script onto the page with the same method used by the configuration form
    javascript. A new get_instance_inline_javascript method is added to
    initialise the block when it's first configured.

    Change-Id: I148a1e8a667c26fe58b3f915768ada4743718c5b
    Signed-off-by: Richard Mansfield <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/797
Committed: http://gitorious.org/mahara/mahara/commit/9496078b005aaba2a80f549c7ee6d513069f8282
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit 9496078b005aaba2a80f549c7ee6d513069f8282
Author: Richard Mansfield <email address hidden>
Date: Tue Oct 25 17:28:38 2011 +1300

    Use function to process get_instance_config_javascript js (bug #845534)

    Moving this code into its own function will allow it to be used for
    block instance rendering javascript as well as the configuration form.

    Change-Id: I42dba8425a8455aaa9faae19d50414e33c5988db
    Signed-off-by: Richard Mansfield <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/808
Committed: http://gitorious.org/mahara/mahara/commit/2c827ce206660aa097b0db1594f7c0a479ec06aa
Submitter: Francois Marier (<email address hidden>)
Branch: 1.4_STABLE

commit 2c827ce206660aa097b0db1594f7c0a479ec06aa
Author: Richard Mansfield <email address hidden>
Date: Tue Oct 25 17:32:23 2011 +1300

    Eval js to rewrite task titles after block configuration (bug #845534)

    When a plans block is first added to the page, the javascript overlay of
    the task titles was not evaluated. This is fixed by moving javascript
    functions for the plans block into a new javascript file and pulling the
    script onto the page with the same method used by the configuration form
    javascript. It also:

    - Rewrites the task title links after the callback from getScript
    - Sets the block's artefactplugin so the js file is found correctly
    - Removes any onclick from task titles before rewriting (in case
      there are two plans blocks on a page)
    - Hides the pagination on first load, as the paginator object is not
      present at that point.

    Signed-off-by: Richard Mansfield <email address hidden>
    Change-Id: I913d8a6fa1f9f2f159dc8076bbdf86bd50b4b588

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/807
Committed: http://gitorious.org/mahara/mahara/commit/f1b422ab6a92358a200d20deb0f78f2c15fcb31b
Submitter: Francois Marier (<email address hidden>)
Branch: 1.4_STABLE

commit f1b422ab6a92358a200d20deb0f78f2c15fcb31b
Author: Richard Mansfield <email address hidden>
Date: Tue Oct 25 17:28:38 2011 +1300

    Use function to process get_instance_config_javascript js (bug #845534)

    Moving this code into its own function will allow it to be used for
    block instance rendering javascript as well as the configuration form.

    Change-Id: I42dba8425a8455aaa9faae19d50414e33c5988db
    Signed-off-by: Richard Mansfield <email address hidden>

Revision history for this message
François Marier (fmarier) wrote :

Hi Kevin,

Are you able to test the two patches that Richard has done for 1.4 and confirm that your problem has been fixed?

  http://gitorious.org/mahara/mahara/commit/f1b422ab6a92358a200d20deb0f78f2c15fcb31b
  http://gitorious.org/mahara/mahara/commit/2c827ce206660aa097b0db1594f7c0a479ec06aa

Cheers,
Francois

Changed in mahara:
status: In Progress → Fix Committed
assignee: Melissa Draper (melissa) → Richard Mansfield (richard-mansfield)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.