gEDA

text-find in gschem has unpredictable results if invisible text is found

Bug #845380 reported by dima kogan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gEDA
Fix Released
Critical
Unassigned
gEDA 1.7.2

Bug Description

When doing "Find specific text" in gschem, if a hidden text string matches, gschem produces unpredictable behavior. This is because it acts on uninitialized data (world_get_single_object_bounds() does nothing since the text is hidden, but its output is used anyway). Patches attached.

Tags: gschem
Revision history for this message
dima kogan (pjhhh3o25) wrote :
Revision history for this message
dima kogan (pjhhh3o25) wrote :
Revision history for this message
dima kogan (pjhhh3o25) wrote :
Revision history for this message
Peter TB Brett (peter-b) wrote :

Sorry for not getting to this sooner. I'll deal with it ASAP.

Changed in geda:
assignee: nobody → Peter TB Brett (peter-b)
importance: Undecided → Critical
milestone: none → 1.7.2
status: New → In Progress
tags: added: gschem
Revision history for this message
gpleda.org commit robot (gpleda-launchpad-robot) wrote :

A commit was made which affects this bug
git master commit 182110f690c51eb53ea1799fd022e87322d742e3
http://git.gpleda.org/?p=gaf.git;a=commit;h=182110f690c51eb53ea1799fd022e87322d742e3

commit 182110f690c51eb53ea1799fd022e87322d742e3
Author: Dima Kogan <email address hidden>
Commit: Peter TB Brett <email address hidden>

    gschem: Move variables closer to where they are used, for clarity

    Signed-off-by: Dima Kogan <email address hidden>
    Reviewed-by: Peter TB Brett <email address hidden>
    Affects-bug: lp-845380

Revision history for this message
gpleda.org commit robot (gpleda-launchpad-robot) wrote :

A commit was made which affects this bug
git master commit 039e012397f2638d1577dd7c80fb862a5503dbfd
http://git.gpleda.org/?p=gaf.git;a=commit;h=039e012397f2638d1577dd7c80fb862a5503dbfd

commit 039e012397f2638d1577dd7c80fb862a5503dbfd
Author: Dima Kogan <email address hidden>
Commit: Peter TB Brett <email address hidden>

    gschem: Fix searching for hidden text.

    searching (and finding) hidden text no longer produces random results
    by looking at uninitialized data.

    Signed-off-by: Dima Kogan <email address hidden>
    Reviewed-by: Peter TB Brett <email address hidden>
    Affects-bug: lp-845380

Revision history for this message
gpleda.org commit robot (gpleda-launchpad-robot) wrote :

A commit was made which affects this bug
git master commit bd7a0be7431df1a2a03027edb96cfde558256cb1
http://git.gpleda.org/?p=gaf.git;a=commit;h=bd7a0be7431df1a2a03027edb96cfde558256cb1

commit bd7a0be7431df1a2a03027edb96cfde558256cb1
Author: Dima Kogan <email address hidden>
Commit: Peter TB Brett <email address hidden>

    gschem: Update optional debug printing to work with the latest code

    Signed-off-by: Dima Kogan <email address hidden>
    Reviewed-by: Peter TB Brett <email address hidden>
    Affects-bug: lp-845380

Peter TB Brett (peter-b)
Changed in geda:
assignee: Peter TB Brett (peter-b) → nobody
status: In Progress → Fix Committed
Peter TB Brett (peter-b)
Changed in geda:
status: Fix Committed → In Progress
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.