cloudpipe vpns fail to get ip
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
High
|
Tushar Patil |
Bug Description
When vpn=true in allocate ip, it attempts to allocate the ip that is reserved in the network. Unfortunately allocate_fixed_ips attempts to ignore reserved ips.
I think this is due to the fact that we are trying to stop users from attempting to select ips like the broadcast address or the network address for vms. My initial suggestion is to remove the line from allocate_fixed_ip that filters based on reserved:
676 fixed_ip_ref = session.
677 filter(
678 filter_
679 filter_
680 filter_
681 with_lockmode(
682 first()
Then we can still use reserved to mean, if you're selecting a random ip, ignore these. (Perhaps we should expose a way to reserve ips). If we want to protect users from launching an instance using the network or broadcast ip (i.e. 10.0.0.0 and 10.0.0.255) then perhaps we shoiuld just delete them from the list of fixed ips (or not add them in the first place)
Related branches
- OpenStack release team: Pending requested
-
Diff: 75 lines (+15/-6)4 files modifiednova/db/api.py (+4/-2)
nova/db/sqlalchemy/api.py (+7/-2)
nova/network/manager.py (+2/-1)
nova/tests/test_network.py (+2/-1)
- Dan Prince (community): Approve
- Brian Waldon (community): Approve
- William Wolf (community): Approve
- Devin Carlen (community): Approve
-
Diff: 75 lines (+15/-6)4 files modifiednova/db/api.py (+4/-2)
nova/db/sqlalchemy/api.py (+7/-2)
nova/network/manager.py (+2/-1)
nova/tests/test_network.py (+2/-1)
Changed in nova: | |
status: | New → Triaged |
importance: | Undecided → High |
assignee: | nobody → Tushar Patil (tpatil) |
Changed in nova: | |
status: | Triaged → In Progress |
Changed in nova: | |
status: | In Progress → Fix Committed |
Changed in nova: | |
milestone: | none → 2011.3 |
Changed in nova: | |
status: | Fix Committed → Fix Released |