Use closures with engine.beginTimer in MIDI Script

[Phillip Whelan]

It would be great to pass functions directly to engine.beginTimer and have it use the same context where the timer is being registered.

Here is an example of what engine.beginTimer can do now

    function doTimer() {
        print("Executed Timer");
    }
    engine.beginTimer(200, "doTimer", 1);

With closures the same code can also be written as such:

    engine.beginTimer(200, function() { print("Executed Timer") }, 1);

Also since the context is being reused this same code actually works:

    function doMidi() {
        this.value = 1;
        engine.beginTimer(200, function() { if (this.value) print("Executed Timer"); }, 1);
    }

I have attached a patch which can be applied to trunk that accomplishes this functionality.

[RJ Skerry-Ryan (rryan)]

Hey Phil,

I see you only store 'this' for function arguments to beginTimer. Is there any reason not to also apply string arguments with the same 'this' as the beginTimer() caller environment's 'this'?

[Sean M. Pappalardo (pegasus-renegadetech)]

Phillip, would you please re-create this patch against the features_controllerAbstraction branch's ControllerEngine? I started to manually merge it but I don't want to screw anything up.

[Phillip Whelan (pwhelan)]

I actually have a working copy with most of the MIDI Script improvements in them merged with CA. I need to spruce it up and re-merge since it has fallen out of sync.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/5976