Non-LoC authority control sets need better coverage in UIs

[Mike Rylander]

In the OPAC authority browse interface and the MARC editor, authority records that lack a known thesaurus value cause problems with some UIs.

 * In the MARC editor, we were only considering the static (LoC) control map
 * in the browse interface, we were assuming a correct thesaurus (related to bug #837522)

Both of these are addressed in http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/miker/acs-ui-repairs via the last three commits.

[Lebbeous Fogle-Weekley (lebbeous)]

Tested and signed off the new commits in collab/miker/acs-ui-repairs and pushed to master.

[Dan Scott (denials)]

I was planning on looking at this, but in the absence of any test records and test cases to demonstrate the unhappy behavior it was a pretty tall hill to climb - finding records, setting up the authority control sets for those records, etc. Would be helpful for bugs such as this in the future.

[Mike Rylander (mrylander)]

Dan, I'll try to be better about attaching a test plan for more complex ones like this. A short test plan looks:

  * Create a new ACS with, say, 'A' for a thesaurus code
  * Restart services (too-aggressive caching somewhere -- still hunting that)
  * Create+Edit to make an authority record for that ACS (don't give it a proper Subj)
  * Link a bib to this authority record

At this point you have an authority record properly linked, but you can't browse it yet, neither in the MARC editor nor in the OPAC.

For the OPAC interface, this branch makes a best-guess at the control_set by looking at (what LoC and, in practice, everyone else, considers) the main entry (a field in the 100-199 range) and finds an ACS that uses that authority field. It's not perfect (they can overlap), but the recommendation in the documentation is to avoid overlapping authority fields, so it's GoodEnough(tm).

For the MARC editor, we were still using the static control_map object in some areas. I believe I've removed all uses of it, replacing those with ACS lookups based on the context bib field. Now right-clicking on a non-LoC controlled field will let you browse existing authority records for use, and create new ones.