Adding multiple copies of one effect causes all to stop working

[townxelliot]

When adding multiple copies of a single effect (e.g. Simple Delay Line), output goes dead.

To reproduce:

1. Create a track, any track.
2. Add an effect.
3. Add the same effect again.
4. Press play. Nothing happens.

I get this error message on the console, e.g. when adding two Simple Delay Lines:

(Jokosher:2632): GStreamer-WARNING **: Name ladspa-delay-5s is not unique in bin InstrumentEffects_25, not adding
Traceback (most recent call last):
  File "/home/ell/Jokosher0.2checkout/jokosher/Jokosher/InstrumentEffectsDialog.py", line 170, in OnTransport
    self.instrument.project.play()
  File "/home/ell/Jokosher0.2checkout/jokosher/Jokosher/Project.py", line 604, in play
    ins.PrepareEffectsBin()
  File "/home/ell/Jokosher0.2checkout/jokosher/Jokosher/Instrument.py", line 678, in PrepareEffectsBin
    self.effectsbin.add(effect)
gst.AddError: Could not add element 'ladspa-delay-5s'
Traceback (most recent call last):
  File "/home/ell/Jokosher0.2checkout/jokosher/Jokosher/InstrumentEffectsDialog.py", line 170, in OnTransport
    self.instrument.project.play()
  File "/home/ell/Jokosher0.2checkout/jokosher/Jokosher/Project.py", line 604, in play
    ins.PrepareEffectsBin()
  File "/home/ell/Jokosher0.2checkout/jokosher/Jokosher/Instrument.py", line 659, in PrepareEffectsBin
    self.effectsbin.remove_pad(self.effectsbinsink)
TypeError: GstElement.remove_pad() argument 1 must be gst.Pad, not None

I'm running on Ubuntu Dapper, installed Jokosher yesterday from runscript, with Intel Corporation 82801FB/FBM/FR/FW/FRW (ICH6 Family) High Definition Audio Controller (rev 03) sound card (on an IBM Z60t laptop).

[Laszlo Pandy (laszlok)]

All the effects code has been rewritten for 0.9, so its been fixed already.