Simplestyle extension helper breaks on spaces in styles (with fix)

[nikitakit]

Simplestyle doesn't work with styles that contain spaces after the colon, e.g. "stop-color: rgb(0,0,0);" (note space after ':') The resulting style will have a color value that begins with a space, which can't be parsed by parseColor.

Proposed fix: strip spaces surrounding style keys and values.
For example, replace [share/extensions/simplestyle.py:: line 179]:
return dict([i.split(":") for i in s.split(";") if len(i)])
with:
return dict([[x.strip() for x in i.split(":")] for i in s.split(";") if len(i)])

[jazzynico (jazzynico)]

Fix committed in the trunk, revision 10610.
Thanks for the patch!

[nikitakit (nikitakit)]

Thanks for committing.

Of course, there are still edge cases falling through the cracks: namely a final space at the end of the style. It could be fixed by changing len(i) to len(i.strip()) or changing s.split(";") to s.strip().split(";")

It might be worth considering writing an actual parser instead of a one-liner.

[jazzynico (jazzynico)]

Back-ported to the 0.48.x branch, revision 9830.