offspring e-mail notification contains incorrect links

[Fathi Boudra]

Previously reported as: https://rt.admin.canonical.com//Ticket/Display.html?id=46509

> On Wed Jun 22 19:40:22 2011, james_w wrote:
>> Please check the build_results_uri setting in the config file. It
>> should
>> have the /build/ at the end I think.
>>
>> I'm not sure why this isn't working given that the links in the HTML
>> served by the webapp are correct and it seems to use that same config
>> value.
>
> I've fixed this on the offspring master, please let us know if you have
> any issues.

It isn't fixed:
http://snapshots.linaro.org//lt-snowball-natty/20110828/0/
http://snapshots.linaro.org//lt-snowball-natty/20110828/0/build-log.txt

"build" is still missing in the URL.

Followed by a chat on IRC:
04:27 < DarrenS> james_w: hi I'm following up with Cody, re the snapshots build URI
04:28 < DarrenS> the config appears to be correct everywhere I've looked so it may be a bug.
04:35 < james_w> DarrenS, build_results_uri is set to the correct thing?
04:36 < DarrenS> james_w: yes
04:38 < james_w> DarrenS, then it sounds like a bug, but one I have no idea where it could be living at this point :-)
04:39 < DarrenS> Cody suggested that a bug report should be filed and he will dig at it.
04:40 < james_w> so, the email notification is sent in-request
04:40 < james_w> but it's not web request
04:40 < james_w> it's part of a cronjob
04:40 < james_w> so I'm guessing it's using a different config to the web frontend
04:40 < james_w> I'm not sure how to work out which config though
04:42 < DarrenS> I had a fair dig and couldn't see anything
04:49 < james_w> DarrenS, would you get me the command run for offspring-master (cron or init script) and any environment set there too please?
04:49 < DarrenS> sure
04:53 < james_w> /srv/config/offspring.cfg is the file that has the correct config for build_results_uri?
04:54 < DarrenS> /srv/offspring.linaro.org/config/offspring.cfg
04:55 < james_w> is the web frontend running under wsgi? If so, is it using config/offspring-web.wsgi in the tree?
04:55 < DarrenS> that's a point, I'll check
04:56 < DarrenS> fyi /srv/offspring.linaro.org/bin/offspring-master is launched as-is via cron
04:58 < DarrenS> james_w: that includes the global cfg
04:59 < james_w> I'm pretty lost by now
05:01 < DarrenS> Cody and I thrashed on it for a bit prior, it may be safe to say this is a bug.
05:02 < james_w> I'm just not sure where to look there, as the code is the same for the emails and the web UI, and the web gets it right
05:02 < james_w> so that's why I'm looking at this process difference

[Fathi Boudra (fboudra)]

It has been fixed. dunno how, when, where.