No warning about missing or unreadable files

Bug #835973 reported by Antoine Amarilli
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
emailgraph
Fix Released
Low
motters

Bug Description

When running:
 $ emailgraph -m foobar
where foobar does not exist or cannot be read because of unsufficient permissions, the following mildly helpful message is shown:
  0 Contacts detected

When running:
 $ emailgraph --dot -m foobar
nothing helpful is output at all.

It would probably be better, when a file cannot be opened for reading, to display it on stderr and exit immediately.

motters (fuzzgun)
Changed in emailgraph:
importance: Undecided → Low
assignee: nobody → motters (fuzzgun)
Revision history for this message
motters (fuzzgun) wrote :

Fix committed in revision 28.

Changed in emailgraph:
status: New → Confirmed
status: Confirmed → Fix Committed
Revision history for this message
Antoine Amarilli (a3nm) wrote :

Thanks for the fix! There remains a problem though: when the program cannot read a file due to insufficient permissions, it will complain that the file is "not found", which is slightly misleading. I would suggest "cannot open FILE: ERROR" where ERROR would be something obtained using errno and strerror.

Revision history for this message
Antoine Amarilli (a3nm) wrote :

Looks like this works fine now. Thanks!

Revision history for this message
motters (fuzzgun) wrote :

There was also a situation where nothing was reported if you didn't specify either a mailbox file or a directory. That should be fixed now too.

Changed in emailgraph:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.