Combining phrases with || (or-ing) doesn't work in search

Bug #834042 reported by Lebbeous Fogle-Weekley
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Status tracked in Main
2.0
Fix Released
Undecided
Unassigned
2.1
Fix Released
Undecided
Unassigned
Main
Fix Released
Undecided
Unassigned

Bug Description

In master, at least, searches like the following do not do what you'd expect.

"conan doyle" || "agatha christie"

Internally, Query Parser seems to generate a query plan that only has &'s, not |'s.

Mike Rylander is already looking at this.

Tags: pullrequest
Revision history for this message
Dan Scott (denials) wrote : Re: [Bug 834042] [NEW] Combining phrases with || (or-ing) doesn't work in search

Confirmed that this a problem with our 2.0 system as well.

FWIW, the query:

keyword:arthur conan doyle || keyword:agatha christie

works. To emphasize what Lebbeous said, phrase searches i.e. "Contains
exactly", seems to introduce the problem.

Revision history for this message
Mike Rylander (mrylander) wrote :

The semantics we want amount to:

  ("conan doyle") || ("agatha christie")

This is embodied in the branch at: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/lp_834042

tags: added: pullrequest
Revision history for this message
Mike Rylander (mrylander) wrote :

Dan, that branch won't merge to 2.0 cleanly (I don't think) but I'll work on 2.0-ifying it tomorrow.

Revision history for this message
Lebbeous Fogle-Weekley (lebbeous) wrote :

Mike's branch works for 2.1 and master. I've signed-off and pushed to those branches.

Revision history for this message
Mike Rylander (mrylander) wrote :
Revision history for this message
Bill Erickson (berick) wrote :

Test 2.0 patch

Revision history for this message
Bill Erickson (berick) wrote :

Meant to say "testing" in my previous comment...

Patch tested in 2.0 and merged into rel_2_0.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.