Deploying formulas no longer works

[Adam Gandelman]

0.5+bzr326-0ensemble1~oneiric1

Deploying any formula to today's daily oneiric AMI as well as the default ensemble AMI results in a traceback in /var/log/ensemble/machine-agent.log:

3.24:2181], sessionId=0x131fcc6ddde000b, negotiated timeout=10000
2011-08-24 17:20:41,984: ensemble.agents.machine@INFO: Machine agent started id:3
2011-08-24 17:20:41,993: ensemble.agents.machine@DEBUG: Units changed old:set([]) new:set(['rabbitmq/0'])
2011-08-24 17:20:41,993: ensemble.agents.machine@DEBUG: Starting service unit: rabbitmq/0 ...
2011-08-24 17:20:42,068: ensemble.agents.machine@DEBUG: Downloading formula local:rabbitmq-49...
2011-08-24 17:20:42,097: ensemble.agents.machine@ERROR: Error starting unit: rabbitmq/0
Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.7/ensemble/agents/machine.py", line 118, in watch_service_units
    yield self.start_service_unit(unit_name)
  File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 1018, in _inlineCallbacks
    result = result.throwExceptionIntoGenerator(g)
  File "/usr/lib/python2.7/dist-packages/twisted/python/failure.py", line 350, in throwExceptionIntoGenerator
    return g.throw(self.type, self.value, self.tb)
  File "/usr/lib/pymodules/python2.7/ensemble/agents/machine.py", line 138, in start_service_unit
    bundle = yield self.download_formula(formula_state)
  File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 1020, in _inlineCallbacks
    result = g.send(result)
  File "/usr/lib/pymodules/python2.7/ensemble/unit/formula.py", line 27, in download_formula
    if formula_state.bundle_url.startswith("file://"):
AttributeError: 'NoneType' object has no attribute 'startswith'

[Kapil Thangavelu (hazmat)]

the s3 url signing algortithm was properly quoting the bucket and key name. fixed directly on trunk.