pal version 0.4.3-6 failed to build in oneiric

[Matthias Klose]

pal version 0.4.3-6 failed to build in oneiric
Link to failed build: https://launchpad.net/ubuntu/+archive/test-rebuild-20110816/+build/2707433

Details about the rebuild:
http://people.ubuntuwire.org/~wgrant/rebuild-ftbfs-test/test-rebuild-20110816-oneiric.html

Direct link to the build log: https://launchpad.net/ubuntu/+archive/test-rebuild-20110816/+build/2707433/+files/buildlog_ubuntu-oneiric-amd64.pal_0.4.3-6_FAILEDTOBUILD.txt.gz

This log snippet might be of interest, since it triggered the matcher 'Purging chroot-autobuild'.
Excerpt 375 lines into the build log:

Using CFLAGS: -Wall -g -O2
Using CPPFLAGS: -I/usr/include -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -DPAL_VERSION="0.4.3" -DPREFIX="/usr" -DG_DISABLE_DEPRECATED -DDEBUG
Using LDFLAGS: -lglib-2.0 -lreadline -lncursesw
 [gcc debug] main.c
main.c: In function 'main':
main.c:705:5: error: unknown type name 'G_CONST_RETURN'
main.c:705:26: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token
main.c:769:20: error: 'charset' undeclared (first use in this function)
main.c:769:20: note: each undeclared identifier is reported only once for each function it appears in
make[2]: *** [tmp.debug/main.o] Error 1
make[2]: Leaving directory `/build/buildd/pal-0.4.3/src'
make[1]: *** [pal] Error 2
make[1]: Leaving directory `/build/buildd/pal-0.4.3'
make: *** [build-stamp] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2
******************************************************************************
Build finished at 20110823-0151
FAILED [dpkg-buildpackage died]
Purging chroot-autobuild/build/buildd/pal-0.4.3

[CarstenHey (c.hey)]

Hi,

I attached an trivial but untested patch that should fix a build failure
with recent glib releases. I'll include it in the next pal upload to
Debian (presumably this week).

Regards
Carsten

[CarstenHey (c.hey)]

* Carsten Hey [2011-08-24 18:52 +0200]:
> I attached an trivial but untested patch that should fix a build failure
> with recent glib releases.

This patch attached to my prior mail was made against a svn snapshot,
the patch for pal 0.4.3 (the version in Debian and Ubuntu) is included
in version 0.4.3-7 uploaded recently to Debian. Both were generated
using:

    sed -i 's/G_CONST_RETURN/const/' src/remind.c src/main.c

Fixing a build failure with recent and future glib versions (in the
meantime I verified that it does) is in my opinion a very good reason
for a new upstream release. If you plan to do so, you could consider
applying some of the patches from [1]. At least two of them are already
in your svn repository.

 [1] http://patch-tracker.debian.org/package/pal/0.4.3-7
     (it might take some time until this page is available)

Regards
Carsten

[Launchpad Janitor (janitor)]

This bug was fixed in the package pal - 0.4.3-7

---------------
pal (0.4.3-7) unstable; urgency=low

  * Replace glib's deprecated G_CONST_RETURN with const. This fixes the
    build failure with recent glib versions. Thanks to Matthias Klose for
    reporting the according FTBFS bug in Ubuntu Oneiric. (LP: #832892)
  * Remove duplicate entry from history.pal. Thanks to Paul Martin for
    reporting; in answer to your question, I assume it was quite funny,
    apart from that. (Closes: #623061)
  * Fix spelling error in pal's man page (s/calender/calendar/).
  * Move the changes introduced in the prior Debian upload to a patch.
    The reason that this was not done initally does not apply anymore.
  * Bump debhelper compat level to 8, adapt dependency on debhelper
    and replace dh_clean -k with dh_prep in debian/rules.
  * Bump standards version to 3.9.2.
  * Keep the old dpkg source format for now and document this in
    debian/source/format. I'll consider switching to "3.0 (quilt)"
    for the next upstream release.
  * Add ${misc:Depends} as dependency in debian/control.
  * Add the targets binary-indep and binary-arch to debian/rules.
  * Remove debian/dirs, it did only contain usr/bin.

 -- Carsten Hey <email address hidden> Sat, 27 Aug 2011 21:25:10 +0200