Unit tests not performed once 'not_working_in_parallel' called

[Garth Wells]

If the function 'not_working_in_parallel("...")' is called in the DOLFIN library during a unit test function, the Python unit test script exits and any remaining tests in a file are not performed.

[Johannes Ring (johannr)]

Isn't it bad to call exit() in a shared library? Wouldn't it be better to return an appropriate error code or throw an exception in not_working_in_parallel?

[Anders Logg (logg)]

On Wed, Aug 24, 2011 at 11:57:46AM -0000, Johannes Ring wrote:
> Isn't it bad to call exit() in a shared library? Wouldn't it be better
> to return an appropriate error code or throw an exception in
> not_working_in_parallel?

Yes, I'm working on it.

--
Anders

[Garth Wells (garth-wells)]

If we add a custom C++ exception for 'not working in parallel', could
the rgression tests catch this and print a graceful message?

Garth

On 24/08/11 08:12, Anders Logg wrote:
> On Wed, Aug 24, 2011 at 11:57:46AM -0000, Johannes Ring wrote:
>> Isn't it bad to call exit() in a shared library? Wouldn't it be better
>> to return an appropriate error code or throw an exception in
>> not_working_in_parallel?
>
> Yes, I'm working on it.
>
> --
> Anders
>

[Johan Hake (johan-hake)]

> If we add a custom C++ exception for 'not working in parallel', could
> the rgression tests catch this and print a graceful message?

I do not think there is an automatic way to solve this.

All C++ expceptions get translated into RuntimeErrors in Python. We then have
to run each test in a try except clause and silently accept an error with the
string "not working in parallel", and otherwise rethrow the exception. But
that sounds quite tedious...

Johan