MyPasswordSafe crashes when it can't write to a VFAT partition

[Peter McCurdy]

Binary package hint: mypasswordsafe

Reproduction steps:

0. Install mypasswordsafe (I have version 0.0.20050615-1)
1. Start MyPasswordSafe.
2. Create a new database, give it a passphrase, add an entry, save it as test.dat.
3. Mount a VFAT filesystem as a user other than your normal user (I happened to have one mounted as root). Say it's called /mnt/vfat.
4. sudo mv test.dat /mnt/vfat/test.dat
5. MyPasswordSafe /mnt/vfat/test.dat
6. Add another entry to the database.
7. Save the database (Ctrl-S)

Expected results: The program reports that it cannot save the database (as it is lacking permissions).

Actual results: It crashes.

Note that if I chmod 444 the file in my home directory (ext3), or use a root-owned file in my home directory with 644 permissions, MyPasswordSafe doesn't crash, and reports "Trouble reading the file" in the status bar. While this isn't strictly true (the trouble was in *writing* the file) it's sure better than crashing.

[Daniel T Chen (crimsun)]

Is this symptom still reproducible in 8.10 alpha?

[Peter McCurdy (peter-mccurdy)]

Yes. The reproduction steps are exactly the same.

[Peter McCurdy (peter-mccurdy)]

I also tried with the updated version (20061216, as opposed to the default 20050615-2) from bug #221893, and it still crashed.

Apport offered to let me report the crash, but I couldn't quite figure out how to get it attached to this bug. I can probably do so if it's absolutely needed, but this bug is extremely reproducible.

[Philip Muškovac (yofel)]

Reproduced on karmic.

[Jeff Buchbinder (rufustfirefly)]

Running this on karmic amd64 yields this on save attempt:

*** stack smashing detected ***: MyPasswordSafe terminated
======= Backtrace: =========
/lib/libc.so.6(__fortify_fail+0x37)[0x7f5eab3905f7]
/lib/libc.so.6(__fortify_fail+0x0)[0x7f5eab3905c0]
MyPasswordSafe[0x417709]
MyPasswordSafe[0x417839]
MyPasswordSafe[0x418247]
MyPasswordSafe[0x416d07]
MyPasswordSafe[0x416d4d]
MyPasswordSafe[0x418c68]
MyPasswordSafe[0x4159ec]
MyPasswordSafe[0x433bbb]
MyPasswordSafe[0x44196c]
/usr/lib/libqt-mt.so.3(_ZN7QObject15activate_signalEP15QConnectionListP8QUObject+0x144)[0x7f5eac88afb4]
/usr/lib/libqt-mt.so.3(_ZN7QObject15activate_signalEi+0x68)[0x7f5eac88cda8]
/usr/lib/libqt-mt.so.3(_ZN7QAction7qt_emitEiP8QUObject+0x2f)[0x7f5eacbb543f]
/usr/lib/libqt-mt.so.3(_ZN7QObject15activate_signalEP15QConnectionListP8QUObject+0x17c)[0x7f5eac88afec]
/usr/lib/libqt-mt.so.3(_ZN7QObject15activate_signalEi+0x68)[0x7f5eac88cda8]
/usr/lib/libqt-mt.so.3(_ZN7QWidget5eventEP6QEvent+0x14d)[0x7f5eac8beebd]
/usr/lib/libqt-mt.so.3(_ZN12QApplication14internalNotifyEP7QObjectP6QEvent+0xc5)[0x7f5eac82c785]
/usr/lib/libqt-mt.so.3(_ZN12QApplication6notifyEP7QObjectP6QEvent+0x21e)[0x7f5eac82d6de]
/usr/lib/libqt-mt.so.3(_ZN9QETWidget19translateMouseEventEPK7_XEvent+0x9c1)[0x7f5eac7cbf31]
/usr/lib/libqt-mt.so.3(_ZN12QApplication15x11ProcessEventEP7_XEvent+0xb36)[0x7f5eac7caf46]
/usr/lib/libqt-mt.so.3(_ZN10QEventLoop13processEventsEj+0x3b2)[0x7f5eac7dd7a2]
/usr/lib/libqt-mt.so.3(_ZN10QEventLoop9enterLoopEv+0x41)[0x7f5eac8435c1]
/usr/lib/libqt-mt.so.3(_ZN10QEventLoop4execEv+0x22)[0x7f5eac843472]
MyPasswordSafe[0x4131ee]
/lib/libc.so.6(__libc_start_main+0xfd)[0x7f5eab2b7abd]
MyPasswordSafe[0x412ca9]
======= Memory map: ========
00400000-004b0000 r-xp 00000000 08:01 274719 /usr/bin/MyPasswordSafe
006b0000-006b1000 r--p 000b0000 08:01 274719 /usr/bin/MyPasswordSafe
006b1000-006b3000 rw-p 000b1000 08:01 274719 /usr/bin/MyPasswordSafe
006b3000-006b4000 rw-p 00000000 00:00 0
019c5000-01d87000 rw-p 00000000 00:00 0 [heap]
7f5ea69d7000-7f5ea69e5000 r-xp 00000000 08:01 274704 /usr/lib/qt3/plugins/inputmethods/libqxim.so
7f5ea69e5000-7f5ea6be5000 ---p 0000e000 08:01 274704 /usr/lib/qt3/plugins/inputmethods/libqxim.so
7f5ea6be5000-7f5ea6be6000 r--p 0000e000 08:01 274704 /usr/lib/qt3/plugins/inputmethods/libqxim.so
7f5ea6be6000-7f5ea6be7000 rw-p 0000f000 08:01 274704 /usr/lib/qt3/plugins/inputmethods/libqxim.so
7f5ea6be7000-7f5ea6c0e000 r-xp 00000000 08:01 274703 /usr/lib/qt3/plugins/inputmethods/libqsimple.so
7f5ea6c0e000-7f5ea6e0d000 ---p 00027000 08:01 274703 /usr/lib/qt3/plugins/inputmethods/libqsimple.so
7f5ea6e0d000-7f5ea6e0e000 r--p 00026000 08:01 274703 /usr/lib/qt3/plugins/inputmethods/libqsimple.so
7f5ea6e0e000-7f5ea6e0f000 rw-p 00027000 08:01 274703 /usr/lib/qt3/plugins/inputmethods/libqsimple.so
7f5ea6e0f000-7f5ea6e14000 r-xp 00000000 08:01 274702 /usr/lib/qt3/plugins/inputmethods/libqimsw-none.so
...