When syncing packages, we should show a confirmation page

[Julian Edwards]

It's considered to be too dangerous to sync a package with no confirmation page. After selecting package(s) to sync a second page should be shown which lists:

    package, old version, new version, changes (including intermediate versions).

For the changes, we need to fix bug 827576 first.

[Raphaël Badin (rvb)]

2 mockups for a possible UI for this:

(number of detailed packages limited [to 15] to make sure the overlay fits on the page)
http://people.canonical.com/~rvb/confirm_overlay_limited.png

(all the details about the packages to be synced)
http://people.canonical.com/~rvb/confirm_overlay_unlimited.png

[Stefano Rivera (stefanor)]

I'd be keen to see changes (i.e. changelog entries)

[Raphaël Badin (rvb)]

Hi Stefano, the problem with having the changes displayed in the confirmation overlay is that the overlay might become huge and since it's "only" a confirmation overlay, having it to fit on the screen seems like a good idea. What do you think?

[Julian Edwards (julian-edwards)]

On Thursday 25 August 2011 18:24:51 you wrote:
> I'd be keen to see changes (i.e. changelog entries)

I don't think there is enough room on the overlay for that, it will get big
very quickly with more than a handful of packages selected.

The main intention of this change was to prevent accidental clicks of the
button submitting unwanted syncs and to review the packages selected. I think
that is adequate for now to close this bug and we can look at other changes in
the future, since Raphaël needs to fix some of the other bugs that you guys
raised.

Thanks.

[Stefano Rivera (stefanor)]

Fine. The proposed confirmation screen (both versions) address my concerns that led to this bug being raised.

[Julian Edwards (julian-edwards)]

On Friday 26 August 2011 10:09:51 you wrote:
> Fine. The proposed confirmation screen (both versions) address my
> concerns that led to this bug being raised.

Great, thanks for your feedback with this bug.

[Launchpad QA Bot (lpqabot)]

Fixed in stable r13829 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/13829>.

[Launchpad QA Bot (lpqabot)]

Fixed in stable r13873 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/13873>.