SubStore.createNew is too easy to misuse
Bug #829872 reported by
Tristan Seligmann
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Divmod Axiom |
Fix Released
|
Low
|
Tristan Seligmann |
Bug Description
createNew takes a list/tuple of path segments; if you pass a string instead, then each letter of the string ends up used as a path component. While this is relatively harmless, it is also unlikely to be the desired behaviour; and in fact, the tests already make this mistake in one place.
Related branches
lp:~divmod-dev/divmod.org/829872-createnew-type-check
- Jonathan Jacobs: Pending requested
- Jean-Paul Calderone: Pending requested
-
Diff: 221 lines (+43/-15)3 files modifiedAxiom/axiom/substore.py (+9/-0)
Axiom/axiom/test/test_batch.py (+10/-6)
Axiom/axiom/test/test_substore.py (+24/-9)
Changed in divmod-axiom: | |
status: | New → Fix Committed |
assignee: | nobody → Tristan Seligmann (mithrandi) |
importance: | Undecided → Low |
Changed in divmod-axiom: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.