glance/common/config.py find_config_file() loads config files from "."

[Dave Walker]

As discovered by Kees Cook on bug #801299

"glance/common/config.py find_config_file() should not load config files from "." (e.g. imagine doing "sudo apt-get install glace" from /tmp and being surprised that ./glance-registry.conf gets loaded during the postinst, writing to arbitrary locations for SQL and logs)"

This implies that find_config_files() needs to be smarter in it's logic, or at least take parameters which overrides/disables this behaviour.

Thanks.

[Adam Gandelman (gandelman-a)]

Resubmitted via the new gerrit review system: https://review.openstack.org/#change,374

[Openstack Gerrit (openstack-gerrit)]

Reviewed: https://review.openstack.org/374
Committed: http://github.com/openstack/glance/commit/706a53396c7a6e7dc8fca9d48d23bd9fab31162a
Submitter: Jenkins
Branch: master

 status fixcommitted
 done

commit 706a53396c7a6e7dc8fca9d48d23bd9fab31162a
Author: Adam Gandelman <email address hidden>
Date: Mon Aug 29 14:36:10 2011 -0700

    Remove PWD from possible config_file_dirs.

    Resolves bug #828719, which can potentially cause problems depending on
    what $PWD commands are executed in.

    Amendment: Also update documentation accordingly.

    Change-Id: Ib2ec4bb07222e51c86b7d8f8ce1dd0e6bb342a64