py-fetch-master-file doesnt detect relative path

Bug #828574 reported by Andreas Roehler
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-mode.el
Invalid
Low
Gennady N. Uraltsev

Bug Description

Docu of py-master-file says:

If the file name has a
relative path, the value of variable `default-directory' for the
buffer is prepended to come up with a file name.

The code of `py-fetch-py-master-file' doesn't contain a provision yet for a relative path.

Revision history for this message
Andreas Roehler (a-roehler) wrote :

Hi Gennady,

might extending that function be a task for you?
Thanks in advance.

BTW did set the importance flag to `low', as not many user will use that actually - that feature has been broken for years.

Nonetheless think it's interesting to have.

Cheers,

Andreas

Changed in python-mode:
assignee: nobody → Andreas Roehler (a-roehler)
importance: Undecided → Low
assignee: Andreas Roehler (a-roehler) → nobody
assignee: nobody → Gennady N. Uraltsev (gennady-uraltsev)
Revision history for this message
Gennady N. Uraltsev (gennady-uraltsev) wrote : Re: [Bug 828574] Re: py-fetch-master-file doesnt detect relative path

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

No problem. I should do it in the next couple of days. I will be out of
town later this week so it may take me a bit longer than usual.

On 08/18/2011 10:52 AM, Andreas Roehler wrote:
> Hi Gennady,
>
> might extending that function be a task for you?
> Thanks in advance.
>
> BTW did set the importance flag to `low', as not many user will use that
> actually - that feature has been broken for years.
>
> Nonetheless think it's interesting to have.
>
> Cheers,
>
> Andreas
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJOTNT2AAoJEGWa0uAesZr4isIP/2h0Lba2HIrpTYzHTkmTbvS7
ZUBFBeNgLpw/YKzmF5OV00deT8ybuO8cShNsbFyJVMCeO5KAeajZAg6DbVPhKAQW
PvmUN4Hw3N0qbSno/XBLXHYmEDCAXFbgQeZJXPo5zuhifQR3Bab1uzGVWx+1iVcY
R6URbV4iP3+1i7XPyAryUBY4Xcg/3BCfpDMzO7eiEAMGWEApWvWzdqiBDG0qr5Kh
Copxm7lebOn/2yd9+N39Wa883esvi6M+HiKcQ4FMXLfoiZbLIoVZjaChCpEmNI5n
ujCdDKABPg/eDkcQaq7nEA8QFoZu8Urul1l7wQCORFRI6dKBjtigqKmaDMjI6gI+
SerBnho/RFBEli6QKPHtM3DRbnAYAgWw7zUJrFotTCRW2plrYEwDQUW7nKEyLtgn
kOuNzdv7p3fZgrK3MkHs+6p1VzvfeYbf8lQgm6/KVlWq6tnJpgbvwq6qB0BrXa0j
kd+8alv7qqJgs0S6jEYSWPQB9bivCTDzCmO8cYWOTI7M/3XiyJ6pbjPqMhwZEju/
CA888rUq089SQUS72Xho+LaV7HSfQTGGEPAuEm0nhX6VDyf4/oRLQDTp9Trag/Yn
gU0+zDEZ/qGmLoXVhBgvAdBqAahdlwOdEN3IbDlz95J9y6BuUtJkuS79yuB/v3EK
HAsGYPL8UoaSeeNNrmuF
=/bVg
-----END PGP SIGNATURE-----

Changed in python-mode:
milestone: none → 6.1
Revision history for this message
Gennady N. Uraltsev (gennady-uraltsev) wrote :

Dear Andreas,

I have studied the question and I cannot actually find the bug. The fact is that every reference to py-master-file in the code is enclosed in a wrapper of this kind:

(expand-file-name py-master-file)

For example in line L2485:

(let* ((filename (expand-file-name py-master-file))

This actually does what is required. I tested it and file-name expansion seems to work.

Bye!

Gennady.

Changed in python-mode:
status: New → Incomplete
Revision history for this message
Andreas Roehler (a-roehler) wrote :

Am 30.08.2011 20:17, schrieb Gennady N. Uraltsev:
> Dear Andreas,
>
> I have studied the question and I cannot actually find the bug. The fact
> is that every reference to py-master-file in the code is enclosed in a
> wrapper of this kind:
>
> (expand-file-name py-master-file)
>
> For example in line L2485:
>
> (let* ((filename (expand-file-name py-master-file))
>
> This actually does what is required. I tested it and file-name expansion
> seems to work.
>
> Bye!
>
> Gennady.
>
> ** Changed in: python-mode
> Status: New => Incomplete
>

Hi Gennady,

thanks a lot. So let's send it onto les invalides :)

Cheers,

Andreas

Changed in python-mode:
status: Incomplete → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.