The librarian-log test detail contains the whole librarian log, not just the log from the currently running test
Bug #828151 reported by
Gavin Panella
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
Gavin Panella | ||
Bug Description
When the LibrarianLayer is active, lp.testing.TestCase adds the
librarian log as a test detail (see attachLibrarianLog and
setUp). However, the librarian log is never rotated or truncated by
LibrarianLayer between tests, so it can grow to many thousands of
irrelevant lines.
One way to fix this is to make LibrarianLayer truncate the log file in
_check_and_reset().
Related branches
lp:~allenap/launchpad/librarian-log-bug-828151
- Brad Crittenden (community): Approve (code)
-
Diff: 122 lines (+64/-4)4 files modifiedlib/canonical/launchpad/daemons/tachandler.py (+18/-0)
lib/canonical/launchpad/daemons/tests/test_tachandler.py (+38/-0)
lib/canonical/librarian/testing/server.py (+5/-0)
lib/canonical/testing/layers.py (+3/-4)
| Changed in launchpad: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Gavin Panella (allenap) |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #1 |
| tags: | added: qa-untestable |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r13741 (http://