Accept "inode/directory" mimetype

Bug #825960 reported by Danielle Foré
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Terminal
Invalid
Undecided
Unassigned

Bug Description

Instead of creating a Marlin extension, Pantheon-terminal should accept the "inode/directory" mimetype. In this way, Pantheon-terminal will appear under the "Open With" options.

description: updated
Revision history for this message
xapantu (xapantu) wrote :

Ok, so, it won't be something shipped with marlin then. We will remove the plugin later, ATM, it is used for testing...

Changed in marlin:
status: New → Won't Fix
milestone: none → 0.1
Revision history for this message
Danielle Foré (danrabbit) wrote :

Upon further evaluation, this shouldn't be a contract either. The .desktop for pantheon-terminal needs to accept the folder mimetype so that the option appears under "open with".

summary: - Make "Open in Terminal" a contract
+ Accept "inode/directory" mimetype
description: updated
Revision history for this message
David Gomes (davidgomes) wrote :

shnatsel fixed this a while ago, by changing the .desktop.

Changed in pantheon-terminal:
status: New → Fix Released
Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

Well, actually, I didn't. With the new system replacing Contractor it should be done via that new system, it's based on desktop files too.

Changed in pantheon-terminal:
status: Fix Released → Invalid
status: Invalid → Confirmed
Revision history for this message
Danielle Foré (danrabbit) wrote :

This shouldn't be a contract, it's an "Open With". It needs to appear in the "Open With" menu, not grouped with actions.

Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

This way I can't open a terminal in the folder I'm currently viewing, only in its subfolders. And that pretty much defeats the point of opening the terminal from file manager.

Revision history for this message
David Gomes (davidgomes) wrote :

I will let this decision to you guys. I would prefer it to be done via "Open with", but I am not aware of its disadvantages/issues.

Revision history for this message
Danielle Foré (danrabbit) wrote :

What I would suggest then is adding the "Open With" menu to the context menu of the current folder. "Open With Terminal" is not a contractor action. Contractor actions are not open ended. It's very clearly and obviously something that belongs in the "Open With" menu, as denoted by the first two words in that string.

David Gomes (davidgomes)
Changed in pantheon-terminal:
milestone: none → 0.1
David Gomes (davidgomes)
Changed in pantheon-terminal:
milestone: 0.1 → 0.2
David Gomes (davidgomes)
Changed in pantheon-terminal:
assignee: nobody → elementary UX Team (elementary-design)
Revision history for this message
Danielle Foré (danrabbit) wrote :

Any reason this has been assigned to UX team?

no longer affects: marlin
Changed in pantheon-terminal:
assignee: elementary UX Team (elementary-design) → nobody
David Gomes (davidgomes)
Changed in pantheon-terminal:
status: Confirmed → Invalid
David Gomes (davidgomes)
Changed in pantheon-terminal:
milestone: 0.2 → none
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.