scribus ftbfs on armel

[Matthias Klose]

see https://launchpad.net/ubuntu/+source/scribus/1.4.0.dfsg~rc3+svn20110401-1ubuntu2/+build/2676572

(please enable verbose build logs)

[ 3%] Building CXX object scribus/fonts/CMakeFiles/scribus_fonts_lib.dir/scfontmetrics.cpp.o
/build/buildd/scribus-1.4.0.dfsg~rc3+svn20110401/scribus/fonts/scfontmetrics.cpp: In function 'QPixmap FontSample(const ScFace&, int, QString, QColor, bool)':
/build/buildd/scribus-1.4.0.dfsg~rc3+svn20110401/scribus/fonts/scfontmetrics.cpp:284:29: error: no matching function for call to 'qMax(qreal&, double)'
/build/buildd/scribus-1.4.0.dfsg~rc3+svn20110401/scribus/fonts/scfontmetrics.cpp:284:29: note: candidate is:
/usr/include/qt4/QtCore/qglobal.h:1116:17: note: template<class T> const T& qMax(const T&, const T&)
/build/buildd/scribus-1.4.0.dfsg~rc3+svn20110401/scribus/fonts/scfontmetrics.cpp:305:29: error: no matching function for call to 'qMax(qreal&, double)'
/build/buildd/scribus-1.4.0.dfsg~rc3+svn20110401/scribus/fonts/scfontmetrics.cpp:305:29: note: candidate is:
/usr/include/qt4/QtCore/qglobal.h:1116:17: note: template<class T> const T& qMax(const T&, const T&)
make[3]: *** [scribus/fonts/CMakeFiles/scribus_fonts_lib.dir/scfontmetrics.cpp.o] Error 1
make[3]: Leaving directory `/build/buildd/scribus-1.4.0.dfsg~rc3+svn20110401/debian/build'
make[2]: *** [scribus/fonts/CMakeFiles/scribus_fonts_lib.dir/all] Error 2

[Dr. David Alan Gilbert (davidgil-uk)]

Looking at Qt's qglobal.h it looks like it defines qreal as float on ARM (and a lot of non-x86)

In those scribus lines we have:

  ymax = qMax(ymax, gp.y());

 ymax is a qreal, gp is a Fpoint and gp.y is going to give a double.

Might get away with changing ymax to be a double, if the later qRound that uses it will take it (it's defined again as taking a qreal, not sure if the implicit cast will work) otherwise it's going to need a cast somewhere.

Dave

[Jani Monoses (jani)]

I filed a patch half a year ago upstream, the code uses qreal and double interchangeably in a lot of places.
It may need adjusting to the newer release.

http://bugs.scribus.net/view.php?id=9850

[Micah Gersten (micahg)]

This patch just made it into Debian, needs a merge.

[Matthias Klose (doko)]

1.4.0.dfsg~rc3+svn20110401-1.1ubuntu1 merged