License page may show a "Finish" button
Bug #825473 reported by
Roberto Alsina
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu One Windows Installer |
Fix Released
|
Critical
|
Roberto Alsina | ||
Bug Description
On the License page:
Depending on how the call to find_credentials works (or how much it takes), it may appear with a "Finish" button.
Solution:
* Start with the overlay visible, and keep it there until we have called find_credentials
* Change the default _next_id for LicensePage so it's not None (which would mean "no next page"=> show Finish)
Related branches
lp:~ralsina/ubuntuone-windows-installer/start-with-overlay
- Diego Sarmentero (community): Approve
- Natalia Bidart (community): Approve
-
Diff: 172 lines (+67/-9)4 files modifiedsetup.py (+2/-1)
ubuntuone_installer/gui/qt/gui.py (+14/-5)
ubuntuone_installer/gui/qt/local_folders.py (+4/-1)
ubuntuone_installer/gui/qt/tests/test_gui.py (+47/-2)
| summary: |
- Buttons are not correct according to spec + License page may show a "Finish" button |
| description: | updated |
| Changed in ubuntuone-windows-installer: | |
| status: | In Progress → Fix Committed |
| tags: | added: u1-windows |
| Changed in ubuntuone-windows-installer: | |
| milestone: | none → 2.0.0 |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
